Thread safety

Author: neocoretechs

src/main/java/org/ros/internal/node/client/RemoteClient.java

@@ -35,7 +35,7 @@ public class RemoteClient implements Runnable {
 	private Socket workerSocket = null; // socket assigned to slave port
 	private SocketAddress workerSocketAddress; //address of slave
 
-	private boolean shouldRun = true; // master service thread control
+	private volatile boolean shouldRun = true; // master service thread control
 	private Object waitHalt = new Object(); 
 
 	ArrayBlockingQueue<RemoteRequestInterface> requests = new ArrayBlockingQueue<RemoteRequestInterface>(1);
@@ -70,7 +70,7 @@ public RemoteClient(String bootNode, int bootPort)  throws IOException {
 	@Override
 	public void run() {
 
-		while(shouldRun ) {
+		while(shouldRun) {
 			try {
 				// sets workerSocket
 				send(requests.take());

src/main/java/org/ros/internal/node/server/TCPWorker.java

@@ -19,7 +19,7 @@
 public class TCPWorker implements Runnable {
 	private static final boolean DEBUG = false;
 	private static final Log log = LogFactory.getLog(TCPWorker.class);
-	public boolean shouldRun = true;
+	public volatile boolean shouldRun = true;
 	private Socket dataSocket;
 	private Object waitHalt = new Object(); 
 	private RpcServer server; // the server we are servicing

src/main/java/org/ros/internal/transport/tcp/AsynchTCPWorker.java

@@ -16,7 +16,7 @@
 public class AsynchTCPWorker implements Runnable {
 	private static final boolean DEBUG = false;
 	private static final Log log = LogFactory.getLog(AsynchTCPWorker.class);
-	public boolean shouldRun = true;
+	public volatile boolean shouldRun = true;
 	private ChannelHandlerContext ctx;
 	private Object waitHalt = new Object();