Skip to content

Commit 79dd640

Browse files
committed
Bring services model fully into pipeline
1 parent 302458d commit 79dd640

File tree

4 files changed

+7
-5
lines changed

4 files changed

+7
-5
lines changed

src/main/java/org/ros/internal/node/DefaultNode.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -300,7 +300,7 @@ public <T, S> ServiceServer<T, S> getServiceServer(String serviceName) {
300300

301301
@Override
302302
public InetSocketAddress lookupServiceUri(GraphName serviceName) {
303-
Response<URI> response =
303+
Response<InetSocketAddress> response =
304304
masterClient.lookupService(slaveServer.toNodeIdentifier().getName(),
305305
resolveName(serviceName).toString());
306306
if (response.getStatusCode() == StatusCode.SUCCESS) {

src/main/java/org/ros/internal/node/client/MasterClient.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -214,9 +214,9 @@ public Response<InetSocketAddress> getUri(GraphName slaveName) {
214214
* @return the {@link URI} of the {@link ServiceServer} with the given name.
215215
* {@link ServiceServer} as a result
216216
*/
217-
public Response<URI> lookupService(GraphName callerName, String serviceName) {
217+
public Response<InetSocketAddress> lookupService(GraphName callerName, String serviceName) {
218218
return Response.fromListCheckedFailure(
219-
rpcEndpoint.lookupService(callerName.toString(), serviceName), new UriResultFactory());
219+
rpcEndpoint.lookupService(callerName.toString(), serviceName), new InetSocketAddressResultFactory());
220220
}
221221

222222
/**

src/main/java/org/ros/internal/node/server/SlaveServer.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -46,6 +46,7 @@ public class SlaveServer extends RpcServer {
4646
private final GraphName nodeName;
4747
private final MasterClient masterClient;
4848
private final TopicParticipantManager topicParticipantManager;
49+
private final ServiceManager serviceManager;
4950
private final ParameterManager parameterManager;
5051
private final TcpRosServer tcpRosServer;
5152
private ServerInvokeMethod invokableMethods;
@@ -59,6 +60,7 @@ public SlaveServer(GraphName nodeName, BindAddress tcpRosBindAddress,
5960
this.nodeName = nodeName;
6061
this.masterClient = master;
6162
this.topicParticipantManager = topicParticipantManager;
63+
this.serviceManager = serviceManager;
6264
this.parameterManager = parameterManager;
6365
try {
6466
invokableMethods = new ServerInvokeMethod(this.getClass().getName(), 0);

src/main/java/org/ros/master/client/MasterStateClient.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -79,8 +79,8 @@ public InetSocketAddress getUri() {
7979
* the name of the {@link ServiceServer} to look up
8080
* @return the {@link URI} of the {@link ServiceServer} with the given name
8181
*/
82-
public URI lookupService(String serviceName) {
83-
Response<URI> result = masterClient.lookupService(caller.getName(), serviceName);
82+
public InetSocketAddress lookupService(String serviceName) {
83+
Response<InetSocketAddress> result = masterClient.lookupService(caller.getName(), serviceName);
8484
return result.getResult();
8585
}
8686

0 commit comments

Comments
 (0)