Apply cargo clippy --fix --all

Signed-off-by: Eval EXEC <execvy@gmail.com>

Author: eval-exec

network/src/tests/peer_registry.rs

@@ -1,4 +1,4 @@
-#![allow(clippy::unchecked_duration_subtraction)]
+#![allow(clippy::unchecked_time_subtraction)]
 
 use super::random_addr;
 use crate::{

shared/src/shared_builder.rs

@@ -530,8 +530,8 @@ fn build_store(
     store_config: StoreConfig,
     ancient_path: Option<PathBuf>,
 ) -> Result<ChainDB, Error> {
-    let store = if store_config.freezer_enable && ancient_path.is_some() {
-        let freezer = Freezer::open(ancient_path.expect("exist checked"))?;
+    let store = if let (true, Some(ancient_path)) = (store_config.freezer_enable, ancient_path) {
+        let freezer = Freezer::open(ancient_path)?;
         ChainDB::new_with_freezer(db, freezer, store_config)
     } else {
         ChainDB::new(db, store_config)

util/launcher/src/lib.rs

@@ -146,34 +146,34 @@ impl Launcher {
         let store = shared.store();
         let stored_spec_hash = store.get_chain_spec_hash();
 
-        if stored_spec_hash.is_none() {
+        if let Some(stored_hash) = stored_spec_hash {
+            if stored_hash == self.args.chain_spec_hash {
+                // stored == configured
+                // do nothing
+            } else if self.args.overwrite_chain_spec {
+                // stored != configured with --overwrite-spec
+                self.write_chain_spec_hash(store)?;
+                info!(
+                    "Overwrite chain spec hash from {} to {}",
+                    stored_hash, self.args.overwrite_chain_spec,
+                );
+            } else if self.args.skip_chain_spec_check {
+                // stored != configured with --skip-spec-check
+                // do nothing
+            } else {
+                // stored != configured
+                eprintln!(
+                    "chain_spec_hash mismatch: Config({}), storage({}). \
+                        If the two chains are compatible, pass command line argument --skip-spec-check; \
+                        otherwise, pass --overwrite-spec to enforce overriding the stored chain spec with the configured one.",
+                    self.args.chain_spec_hash, stored_hash
+                );
+                return Err(ExitCode::Config);
+            }
+        } else {
             // fresh yet
             self.write_chain_spec_hash(store)?;
             info!("Touch chain spec hash: {}", self.args.chain_spec_hash);
-        } else if stored_spec_hash.as_ref() == Some(&self.args.chain_spec_hash) {
-            // stored == configured
-            // do nothing
-        } else if self.args.overwrite_chain_spec {
-            // stored != configured with --overwrite-spec
-            self.write_chain_spec_hash(store)?;
-            info!(
-                "Overwrite chain spec hash from {} to {}",
-                stored_spec_hash.expect("checked"),
-                self.args.overwrite_chain_spec,
-            );
-        } else if self.args.skip_chain_spec_check {
-            // stored != configured with --skip-spec-check
-            // do nothing
-        } else {
-            // stored != configured
-            eprintln!(
-                "chain_spec_hash mismatch: Config({}), storage({}). \
-                    If the two chains are compatible, pass command line argument --skip-spec-check; \
-                    otherwise, pass --overwrite-spec to enforce overriding the stored chain spec with the configured one.",
-                self.args.chain_spec_hash,
-                stored_spec_hash.expect("checked")
-            );
-            return Err(ExitCode::Config);
         }
         Ok(())
     }

util/systemtime/src/test_faketime.rs

@@ -5,7 +5,9 @@ mod tests_faketime {
 
     #[test]
     fn test_basic() {
-        assert!(cfg!(feature = "enable_faketime"));
+        const {
+            assert!(cfg!(feature = "enable_faketime"));
+        }
 
         let faketime_guard = faketime();