Skip to content

Commit d876cfd

Browse files
committed
Url: fixed empty query [Closes #48]
1 parent 255a707 commit d876cfd

File tree

2 files changed

+6
-1
lines changed

2 files changed

+6
-1
lines changed

src/Http/Url.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -348,7 +348,7 @@ public function getFragment()
348348
public function getAbsoluteUrl()
349349
{
350350
return $this->getHostUrl() . $this->path
351-
. ($this->query ? '?' . $this->getQuery() : '')
351+
. (($tmp = $this->getQuery()) ? '?' . $tmp : '')
352352
. ($this->fragment === '' ? '' : '#' . $this->fragment);
353353
}
354354

tests/Http/Url.query.phpt

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -59,3 +59,8 @@ Assert::same( array('arg' => 'value', 'arg2' => 'def'), $url->getQueryParameter
5959
$url->setQueryParameter('arg2', NULL);
6060
Assert::same( NULL, $url->getQueryParameter('arg2') );
6161
Assert::same( array('arg' => 'value', 'arg2' => NULL), $url->getQueryParameters() );
62+
63+
64+
$url = new Url('http://hostname/path?arg=value');
65+
$url->setQuery(array(NULL));
66+
Assert::same( 'http://hostname/path', $url->getAbsoluteUrl() );

0 commit comments

Comments
 (0)