From d50fbfe37ddf03b10609c36e5d5d777d4e859acb Mon Sep 17 00:00:00 2001 From: Ferdinand Thiessen Date: Thu, 26 Feb 2026 14:14:03 +0100 Subject: [PATCH 1/2] fix(files_external): boolean comparison of array To check if there are no missing required dependencies we need to check if the required dependencies are **empty** because `!array` is still true. Signed-off-by: Ferdinand Thiessen --- apps/files_external/lib/Lib/DependencyTrait.php | 2 +- apps/files_external/lib/Service/BackendService.php | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/apps/files_external/lib/Lib/DependencyTrait.php b/apps/files_external/lib/Lib/DependencyTrait.php index 6c342c1990bbe..745231255b237 100644 --- a/apps/files_external/lib/Lib/DependencyTrait.php +++ b/apps/files_external/lib/Lib/DependencyTrait.php @@ -28,7 +28,7 @@ public function checkDependencies() { * * @return MissingDependency[] Unsatisfied required dependencies */ - public function checkRequiredDependencies() { + public function checkRequiredDependencies(): array { return array_filter( $this->checkDependencies(), fn (MissingDependency $dependency) => !$dependency->isOptional() diff --git a/apps/files_external/lib/Service/BackendService.php b/apps/files_external/lib/Service/BackendService.php index 2c1610812357c..dd8a2ae93eb3d 100644 --- a/apps/files_external/lib/Service/BackendService.php +++ b/apps/files_external/lib/Service/BackendService.php @@ -178,7 +178,7 @@ public function getBackends() { * @return Backend[] */ public function getAvailableBackends() { - return array_filter($this->getBackends(), fn (Backend $backend) => !$backend->checkRequiredDependencies()); + return array_filter($this->getBackends(), fn (Backend $backend) => empty($backend->checkRequiredDependencies())); } /** From 69a5db46bdcf4c34a2bd12cbe918fe6c365aeaae Mon Sep 17 00:00:00 2001 From: Ferdinand Thiessen Date: Fri, 27 Feb 2026 14:31:42 +0100 Subject: [PATCH 2/2] fix: code style Co-authored-by: Carl Schwan Signed-off-by: Ferdinand Thiessen --- apps/files_external/lib/Service/BackendService.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/apps/files_external/lib/Service/BackendService.php b/apps/files_external/lib/Service/BackendService.php index dd8a2ae93eb3d..271ffa7695ff5 100644 --- a/apps/files_external/lib/Service/BackendService.php +++ b/apps/files_external/lib/Service/BackendService.php @@ -178,7 +178,7 @@ public function getBackends() { * @return Backend[] */ public function getAvailableBackends() { - return array_filter($this->getBackends(), fn (Backend $backend) => empty($backend->checkRequiredDependencies())); + return array_filter($this->getBackends(), fn (Backend $backend) => $backend->checkRequiredDependencies() === []); } /**