-
Notifications
You must be signed in to change notification settings - Fork 87
add option to disable inline formulas in markdown #780
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@mk This looks pretty good imo. I will bump markdown in bb and then the tests should work in bb too. Do we need to support markdown config in other places, e.g. via a system property? Or one system property with a clerk config to rule them all? |
I need to think more about this. Would leave this pr to only add the notebook metadata. We can start collecting use cases for a global clerk config in an issue and then think about how to solve it separately. |
We probably don't even need an issue, we can wait for people to create one after they want more than just the notebook annotation. Restricting to just notebook metadata for now sounds good. |
|
@mk Note that your last change makes this not work anymore: (ns ^{:nextjournal.clerk/markdown {:disable-inline-formulas true}}
scratch
(:require [nextjournal.clerk :as clerk]))Like functions, Clojure has two ways to add metadata to the namespace: on the name or as a separate map |
Allow setting
{:nextjournal.clerk/markdown {:disable-inline-formulas true}}as ns metadata to disable markdown parsing of $-delimited inline formulas. Fixes #775.