Fix Linq failure on null parameter value

HQL is ill equipped for guessing types of null parameters.
We should keep doing that on Linq side.

Fix #2833

Author: fredericDelaporte

src/NHibernate.Test/Async/Linq/LinqQuerySamples.cs

@@ -14,6 +14,7 @@
 using System.Linq;
 using NHibernate.DomainModel.Northwind.Entities;
 using NSubstitute;
+using NSubstitute.ExceptionExtensions;
 using NUnit.Framework;
 using NHibernate.Linq;
 
@@ -1370,5 +1371,19 @@ from s2 in sup2.DefaultIfEmpty()
 				Assert.That(GetTotalOccurrences(sql, "left outer join"), Is.EqualTo(2));
 			}
 		}
+
+		[Test]
+		public void ReplaceFunctionWithNullArgumentAsync()
+		{
+			var query = from e in db.Employees
+			            select e.FirstName.Replace(e.LastName, null);
+			List<string> results = null;
+			Assert.That(
+				async () =>
+				{
+					results = await (query.ToListAsync());
+				}, Throws.Nothing, "Expected REPLACE(FirstName, LastName, NULL) to be supported");
+			Assert.That(results, Is.Not.Null);
+		}
 	}
 }

src/NHibernate.Test/Linq/LinqQuerySamples.cs

@@ -4,6 +4,7 @@
 using System.Linq;
 using NHibernate.DomainModel.Northwind.Entities;
 using NSubstitute;
+using NSubstitute.ExceptionExtensions;
 using NUnit.Framework;
 
 namespace NHibernate.Test.Linq
@@ -1955,6 +1956,20 @@ public void DLinq2C()
 
 			Assert.That(!q.Any(orderid => withNullShippingDate.Contains(orderid)));
 		}
+
+		[Test]
+		public void ReplaceFunctionWithNullArgument()
+		{
+			var query = from e in db.Employees
+			            select e.FirstName.Replace(e.LastName, null);
+			List<string> results = null;
+			Assert.That(
+				() =>
+				{
+					results = query.ToList();
+				}, Throws.Nothing, "Expected REPLACE(FirstName, LastName, NULL) to be supported");
+			Assert.That(results, Is.Not.Null);
+		}
 	}
 
 	public class ParentChildBatch<T, TKey, TSub>

src/NHibernate/Linq/Visitors/ParameterTypeLocator.cs

@@ -156,7 +156,7 @@ private static IType GetParameterType(
 				return candidateType;
 			}
 
-			if (visitor.NotGuessableConstants.Contains(constantExpression))
+			if (visitor.NotGuessableConstants.Contains(constantExpression) && constantExpression.Value != null)
 			{
 				return null;
 			}