Merge pull request #692 from fredericDelaporte/NH-3905

NH-3905 - upgrade async generator and regen

Author: fredericDelaporte

Tools/packages.config

@@ -7,6 +7,6 @@
   <package id="NUnit.Extension.NUnitV2ResultWriter" version="3.6.0" targetFramework="net461" />
   <package id="NUnit.Extension.TeamCityEventListener" version="1.0.2" targetFramework="net461" />
   <package id="NUnit.Extension.VSProjectLoader" version="3.6.0" targetFramework="net461" />
-  <package id="CSharpAsyncGenerator.CommandLine" version="0.4.4" targetFramework="net461" />
+  <package id="CSharpAsyncGenerator.CommandLine" version="0.5.0" targetFramework="net461" />
   <package id="vswhere" version="2.1.4" targetFramework="net461" />
 </packages>

doc/reference/modules/quickstart.xml

@@ -420,6 +420,12 @@ finally
             cases.
         </para>
 
+        <para>
+            Since NHibernate 5.0, the session and its queries IO bound methods have async counterparts.
+            Each call to an async method must be awaited before further interacting with the session or
+            its queries.
+        </para>
+
     </sect1>
 
     <sect1 id="quickstart-summary">

doc/reference/modules/transactions.xml

@@ -93,6 +93,11 @@
                     Never access the same <literal>ISession</literal> in two concurrent threads.
                     An <literal>ISession</literal> is usually only a single unit-of-work!
                 </para>
+                <para>
+                    Since NHibernate 5.0, the session and its queries IO bound methods have async counterparts.
+                    Each call to an async method must be awaited before further interacting with the session or
+                    its queries.
+                </para>
             </listitem>
         </itemizedlist>
     </sect1>

src/AsyncGenerator.yml

@@ -184,8 +184,6 @@
     - hasAttributeName: TestAttribute
     - hasAttributeName: TheoryAttribute
     typeConversion:
-    - conversion: Ignore
-      name: NorthwindDbCreator
     - conversion: Ignore
       name: ObjectAssert
     - conversion: Ignore
@@ -200,9 +198,13 @@
       rule: IsTestCase
     - conversion: Ignore
       anyBaseTypeRule: IsTestCase
+    ignoreSearchForMethodReferences:
+    - hasAttributeName: TheoryAttribute
+    - hasAttributeName: TestAttribute
     ignoreDocuments:
     - filePathEndsWith: Linq\MathTests.cs
     - filePathEndsWith: Linq\ExpressionSessionLeakTest.cs
+    - filePathEndsWith: Linq\NorthwindDbCreator.cs
     cancellationTokens:
       withoutCancellationToken:
       - hasAttributeName: TestAttribute

src/NHibernate.DomainModel/Async/CustomPersister.cs

@@ -26,9 +26,6 @@ namespace NHibernate.DomainModel
 {
 	using System.Threading.Tasks;
 	using System.Threading;
-	/// <content>
-	/// Contains generated async methods
-	/// </content>
 	public partial class CustomPersister : IEntityPersister
 	{
 

src/NHibernate.Test/Async/ConnectionStringTest/NamedConnectionStringFixture.cs

@@ -20,9 +20,6 @@ namespace NHibernate.Test.ConnectionStringTest
 	using System.Threading.Tasks;
 	using System.Threading;
 
-	/// <content>
-	/// Contains generated async methods
-	/// </content>
 	public partial class MockConnectionProvider : ConnectionProvider
 	{
 

src/NHibernate.Test/Async/DebugConnectionProvider.cs

@@ -19,9 +19,6 @@ namespace NHibernate.Test
 {
 	using System.Threading.Tasks;
 	using System.Threading;
-	/// <content>
-	/// Contains generated async methods
-	/// </content>
 	public partial class DebugConnectionProvider : DriverConnectionProvider
 	{
 

src/NHibernate.Test/Async/DebugSessionFactory.cs

@@ -37,9 +37,6 @@ namespace NHibernate.Test
 {
 	using System.Threading.Tasks;
 	using System.Threading;
-	/// <content>
-	/// Contains generated async methods
-	/// </content>
 	public partial class DebugSessionFactory : ISessionFactoryImplementor
 	{
 

src/NHibernate.Test/Async/DynamicProxyTests/PeVerifier.cs

@@ -16,11 +16,6 @@
 namespace NHibernate.Test.DynamicProxyTests
 {
 	using System.Threading.Tasks;
-	
-	/// <content>
-	/// Contains generated async methods
-	/// </content>
-
 	public partial class PeVerifier
 	{
 

src/NHibernate.Test/Async/Events/Collections/CollectionListeners.cs

@@ -17,9 +17,6 @@
 
 namespace NHibernate.Test.Events.Collections
 {
-	/// <content>
-	/// Contains generated async methods
-	/// </content>
 	public partial class CollectionListeners
 	{
 
@@ -32,9 +29,6 @@ public partial class CollectionListeners
 
 		#region Nested type: InitializeCollectionListener
 
-		/// <content>
-		/// Contains generated async methods
-		/// </content>
 		public partial class InitializeCollectionListener : DefaultInitializeCollectionEventListener, IListener
 		{
 
@@ -53,9 +47,6 @@ public override async Task OnInitializeCollectionAsync(InitializeCollectionEvent
 
 		#region Nested type: PostCollectionRecreateListener
 
-		/// <content>
-		/// Contains generated async methods
-		/// </content>
 		public partial class PostCollectionRecreateListener : AbstractListener, IPostCollectionRecreateEventListener
 		{
 
@@ -81,9 +72,6 @@ public Task OnPostRecreateCollectionAsync(PostCollectionRecreateEvent @event, Ca
 
 		#region Nested type: PostCollectionRemoveListener
 
-		/// <content>
-		/// Contains generated async methods
-		/// </content>
 		public partial class PostCollectionRemoveListener : AbstractListener, IPostCollectionRemoveEventListener
 		{
 
@@ -109,9 +97,6 @@ public Task OnPostRemoveCollectionAsync(PostCollectionRemoveEvent @event, Cancel
 
 		#region Nested type: PostCollectionUpdateListener
 
-		/// <content>
-		/// Contains generated async methods
-		/// </content>
 		public partial class PostCollectionUpdateListener : AbstractListener, IPostCollectionUpdateEventListener
 		{
 
@@ -137,9 +122,6 @@ public Task OnPostUpdateCollectionAsync(PostCollectionUpdateEvent @event, Cancel
 
 		#region Nested type: PreCollectionRecreateListener
 
-		/// <content>
-		/// Contains generated async methods
-		/// </content>
 		public partial class PreCollectionRecreateListener : AbstractListener, IPreCollectionRecreateEventListener
 		{
 
@@ -165,9 +147,6 @@ public Task OnPreRecreateCollectionAsync(PreCollectionRecreateEvent @event, Canc
 
 		#region Nested type: PreCollectionRemoveListener
 
-		/// <content>
-		/// Contains generated async methods
-		/// </content>
 		public partial class PreCollectionRemoveListener : AbstractListener, IPreCollectionRemoveEventListener
 		{
 
@@ -193,9 +172,6 @@ public Task OnPreRemoveCollectionAsync(PreCollectionRemoveEvent @event, Cancella
 
 		#region Nested type: PreCollectionUpdateListener
 
-		/// <content>
-		/// Contains generated async methods
-		/// </content>
 		public partial class PreCollectionUpdateListener : AbstractListener, IPreCollectionUpdateEventListener
 		{