NH-3700 - Remove CodeDom BytecodeProviderImpl (#689)

* NH-3700 - Remove CodeDom BytecodeProviderImpl

The CodeDom BytecodeProviderImpl was intended for .Net 1.1 and has not
been the default for many years. It doesn't actually work currently.

Author: ngbrown

src/NHibernate.DomainModel/NHSpecific/GetSetHelper.cs

@@ -3,7 +3,7 @@
 namespace NHibernate.DomainModel.NHSpecific
 {
 	/// <summary>
-	/// Test the ability of CodeDOM bytecode provider to generate code that
+	/// Test the ability of bytecode provider to generate code that
 	/// can set a value type from a null.
 	/// </summary>
 	public class GetSetHelper
@@ -104,4 +104,4 @@ public int ID
 
 		#endregion
 	}
-}
+}

src/NHibernate.Test/CfgTest/ConfigurationSchemaFixture.cs

@@ -40,7 +40,7 @@ public void IgnoreSystemOutOfAppConfig()
 			string xml =
 			@"<?xml version='1.0' encoding='utf-8' ?>
 <hibernate-configuration xmlns='urn:nhibernate-configuration-2.2'>
-		<bytecode-provider type='codedom'/>
+		<bytecode-provider type='lcg'/>
 		<reflection-optimizer use='false'/>
 		<session-factory name='MyFactoryName'>
 		</session-factory>
@@ -59,7 +59,7 @@ public void EmptyFactoryNotAllowed()
 			string xml =
 			@"<?xml version='1.0' encoding='utf-8' ?>
 <hibernate-configuration xmlns='urn:nhibernate-configuration-2.2'>
-		<bytecode-provider type='codedom'/>
+		<bytecode-provider type='lcg'/>
 </hibernate-configuration>";
 
 			XmlTextReader xtr = new XmlTextReader(xml, XmlNodeType.Document, null);

src/NHibernate/Bytecode/CodeDom/BytecodeProviderImpl.cs

@@ -68,8 +68,6 @@ internal static string ToConfigurationString(this BytecodeProviderType source)
 		{
 			switch (source)
 			{
-				case BytecodeProviderType.Codedom:
-					return "codedom";
 				case BytecodeProviderType.Lcg:
 					return "lcg";
 				default:

src/NHibernate/Cfg/ConfigurationSchema/CfgXmlHelper.cs

@@ -10,8 +10,6 @@ namespace NHibernate.Cfg.ConfigurationSchema
 	/// </summary>
 	public enum BytecodeProviderType
 	{
-		/// <summary>Xml value: codedom</summary>
-		Codedom,
 		/// <summary>Xml value: lcg</summary>
 		Lcg,
 		/// <summary>Xml value: null</summary>

src/NHibernate/Cfg/ConfigurationSchema/HibernateConfiguration.cs

@@ -370,8 +370,6 @@ private static IBytecodeProvider BuildBytecodeProvider(string providerName)
 		{
 			switch (providerName)
 			{
-				case "codedom":
-					return new Bytecode.CodeDom.BytecodeProviderImpl();
 				case "lcg":
 					return new Bytecode.Lightweight.BytecodeProviderImpl();
 				case "null":

src/NHibernate/Cfg/Environment.cs

@@ -13,9 +13,8 @@
 				<xs:element ref="bytecode-provider" minOccurs="0" maxOccurs="1" >
 					<xs:annotation>
 						<xs:documentation>
-							There are 3 default short-cut values
+							There are 2 default short-cut values
 							- lcg     : default for .NET2.0 and higher.
-							- codedom : CodeDOM-based bytecode provider (mostly for .NET1.1).
 							- null    : Disable the reflection optimization completely.
 							In addition you can specify the AssemblyQualifiedName of your custom bytecode-provider (implementation of IBytecodeProvider).
 							Note: the bytecode-provider will be effective only when specified in the app.config or web.config.
@@ -257,7 +256,6 @@
 			<xs:attribute name="type" default="lcg">
 				<xs:simpleType>
 					<xs:restriction base="xs:string">
-						<xs:enumeration value="codedom" />
 						<xs:enumeration value="lcg" />
 						<xs:enumeration value="null" />
 					</xs:restriction>