NH-3900 - Make sources of TestCaseSource static.

Author: ngbrown

src/NHibernate.Test/CfgTest/AccessorsSerializableTest.cs

@@ -9,26 +9,26 @@ public class AccessorsSerializableTest
 	{
 		private static System.Type[] accessors = typeof (IPropertyAccessor).Assembly.GetTypes().Where(t => t.Namespace == typeof (IPropertyAccessor).Namespace && t.GetInterfaces().Contains(typeof (IPropertyAccessor))).ToArray();
 
-		[Test, TestCaseSource("accessors")]
+		[Test, TestCaseSource(nameof(accessors))]
 		public void AllAccessorsAreMarkedAsSerializable(System.Type concreteAccessor)
 		{
 			Assert.That(concreteAccessor, Has.Attribute<SerializableAttribute>());
 		}
 
 		private static System.Type[] setters = typeof(ISetter).Assembly.GetTypes().Where(t => t.Namespace == typeof(ISetter).Namespace && t.GetInterfaces().Contains(typeof(ISetter))).ToArray();
 
-		[Test, TestCaseSource("setters")]
+		[Test, TestCaseSource(nameof(setters))]
 		public void AllSettersAreMarkedAsSerializable(System.Type concreteAccessor)
 		{
 			Assert.That(concreteAccessor, Has.Attribute<SerializableAttribute>());
 		}
 
 		private static System.Type[] getters = typeof(IGetter).Assembly.GetTypes().Where(t => t.Namespace == typeof(IGetter).Namespace && t.GetInterfaces().Contains(typeof(IGetter))).ToArray();
 
-		[Test, TestCaseSource("getters")]
+		[Test, TestCaseSource(nameof(getters))]
 		public void AllGettersAreMarkedAsSerializable(System.Type concreteAccessor)
 		{
 			Assert.That(concreteAccessor, Has.Attribute<SerializableAttribute>());
 		}
 	}
-}
+}

src/NHibernate.Test/DialectTest/FunctionTests/SequenceSupportFixture.cs

@@ -16,7 +16,7 @@ public class SequenceSupportFixture
 		/// <summary>
 		/// Test case data source for DialectSupportingSequencesMustFullfillSequenceContract().
 		/// </summary>
-		private IEnumerable<System.Type> GetAllDialectTypes()
+		private static IEnumerable<System.Type> GetAllDialectTypes()
 		{
 			var dialectBaseType = typeof(NHibernate.Dialect.Dialect);
 
@@ -26,7 +26,7 @@ public class SequenceSupportFixture
 		}
 
 
-		[TestCaseSource("GetAllDialectTypes")]
+		[TestCaseSource(nameof(GetAllDialectTypes))]
 		public void DialectSupportingSequencesMustFullfillSequenceContract(System.Type dialectType)
 		{
 			var dialect = (NHibernate.Dialect.Dialect)Activator.CreateInstance(dialectType);
@@ -51,4 +51,4 @@ public void DialectSupportingSequencesMustFullfillSequenceContract(System.Type d
 
 		}
 	}
-}
+}

src/NHibernate.Test/DialectTest/FunctionTests/SubstringSupportFixture.cs

@@ -14,7 +14,7 @@ public class SubstringSupportFixture
 		/// <summary>
 		/// Test case data source for DialectShouldUseCorrectSubstringImplementation().
 		/// </summary>
-		private IEnumerable<System.Type> GetAllDialectTypes()
+		private static IEnumerable<System.Type> GetAllDialectTypes()
 		{
 			var dialectBaseType = typeof(NHibernate.Dialect.Dialect);
 
@@ -24,7 +24,7 @@ public class SubstringSupportFixture
 		}
 
 
-		[TestCaseSource("GetAllDialectTypes")]
+		[TestCaseSource(nameof(GetAllDialectTypes))]
 		public void DialectShouldUseCorrectSubstringImplementation(System.Type dialectType)
 		{
 			var dialect = (NHibernate.Dialect.Dialect)Activator.CreateInstance(dialectType);
@@ -49,4 +49,4 @@ public void DialectShouldUseCorrectSubstringImplementation(System.Type dialectTy
 
 		}
 	}
-}
+}

src/NHibernate.Test/Linq/WhereTests.cs

@@ -759,7 +759,7 @@ public void CanUseCompareInQueryWithNonConstantZero()
 
 
 		[Test(Description = "NH-3366")]
-		[TestCaseSource(typeof(WhereTests), "CanUseCompareInQueryDataSource")]
+		[TestCaseSource(typeof(WhereTests), nameof(CanUseCompareInQueryDataSource))]
 		public void CanUseCompareInQuery(Expression<Func<Product, bool>> expression, int expectedCount, bool expectCase)
 		{
 			using (var ls = new SqlLogSpy())
@@ -774,7 +774,7 @@ public void CanUseCompareInQuery(Expression<Func<Product, bool>> expression, int
 		}
 
 
-		private List<object[]> CanUseCompareInQueryDataSource()
+		private static List<object[]> CanUseCompareInQueryDataSource()
 		{
 			return new List<object[]>
 				{