Comment Linq to Objects query

Author: maca88

src/NHibernate.Test/Async/Linq/LinqQuerySamples.cs

@@ -1285,24 +1285,24 @@ public async Task DLinqJoin9LeftJoinAsync(bool useCrossJoin)
 				Assert.Ignore("Dialect does not support cross join.");
 			}
 
-			ICollection expected, actual;
-			expected =
-				(from o in db.Orders.ToList()
-				from p in db.Products.ToList()
-				join d in db.OrderLines.ToList()
-					on new {o.OrderId, p.ProductId} equals new {d.Order.OrderId, d.Product.ProductId}
-					into details
-				from d in details.DefaultIfEmpty()
-				where d != null && d.UnitPrice > 50
-				select new {o.OrderId, p.ProductId, d.UnitPrice}).ToList();
+			// The expected collection can be obtained from the below Linq to Objects query.
+			//var expected =
+			//	(from o in db.Orders.ToList()
+			//	 from p in db.Products.ToList()
+			//	 join d in db.OrderLines.ToList()
+			//		 on new { o.OrderId, p.ProductId } equals new { d.Order.OrderId, d.Product.ProductId }
+			//		 into details
+			//	 from d in details.DefaultIfEmpty()
+			//	 where d != null && d.UnitPrice > 50
+			//	 select new { o.OrderId, p.ProductId, d.UnitPrice }).ToList();
 
 			using (var substitute = SubstituteDialect())
 			using (var sqlSpy = new SqlLogSpy())
 			{
 				ClearQueryPlanCache();
 				substitute.Value.SupportsCrossJoin.Returns(useCrossJoin);
 
-				actual =
+				var actual =
 					await ((from o in db.Orders
 					from p in db.Products
 					join d in db.OrderLines
@@ -1313,11 +1313,10 @@ from d in details.DefaultIfEmpty()
 					select new {o.OrderId, p.ProductId, d.UnitPrice}).ToListAsync());
 
 				var sql = sqlSpy.GetWholeLog();
+				Assert.That(actual.Count, Is.EqualTo(163));
 				Assert.That(sql, Does.Contain(useCrossJoin ? "cross join" : "inner join"));
 				Assert.That(GetTotalOccurrences(sql, "left outer join"), Is.EqualTo(1));
 			}
-
-			Assert.AreEqual(expected.Count, actual.Count);
 		}
 
 		[Category("JOIN")]

src/NHibernate.Test/Linq/LinqQuerySamples.cs

@@ -1829,24 +1829,24 @@ public void DLinqJoin9LeftJoin(bool useCrossJoin)
 				Assert.Ignore("Dialect does not support cross join.");
 			}
 
-			ICollection expected, actual;
-			expected =
-				(from o in db.Orders.ToList()
-				from p in db.Products.ToList()
-				join d in db.OrderLines.ToList()
-					on new {o.OrderId, p.ProductId} equals new {d.Order.OrderId, d.Product.ProductId}
-					into details
-				from d in details.DefaultIfEmpty()
-				where d != null && d.UnitPrice > 50
-				select new {o.OrderId, p.ProductId, d.UnitPrice}).ToList();
+			// The expected collection can be obtained from the below Linq to Objects query.
+			//var expected =
+			//	(from o in db.Orders.ToList()
+			//	 from p in db.Products.ToList()
+			//	 join d in db.OrderLines.ToList()
+			//		 on new { o.OrderId, p.ProductId } equals new { d.Order.OrderId, d.Product.ProductId }
+			//		 into details
+			//	 from d in details.DefaultIfEmpty()
+			//	 where d != null && d.UnitPrice > 50
+			//	 select new { o.OrderId, p.ProductId, d.UnitPrice }).ToList();
 
 			using (var substitute = SubstituteDialect())
 			using (var sqlSpy = new SqlLogSpy())
 			{
 				ClearQueryPlanCache();
 				substitute.Value.SupportsCrossJoin.Returns(useCrossJoin);
 
-				actual =
+				var actual =
 					(from o in db.Orders
 					from p in db.Products
 					join d in db.OrderLines
@@ -1857,11 +1857,10 @@ from d in details.DefaultIfEmpty()
 					select new {o.OrderId, p.ProductId, d.UnitPrice}).ToList();
 
 				var sql = sqlSpy.GetWholeLog();
+				Assert.That(actual.Count, Is.EqualTo(163));
 				Assert.That(sql, Does.Contain(useCrossJoin ? "cross join" : "inner join"));
 				Assert.That(GetTotalOccurrences(sql, "left outer join"), Is.EqualTo(1));
 			}
-
-			Assert.AreEqual(expected.Count, actual.Count);
 		}
 
 		[Category("JOIN")]