NH-3433 - Criteria/QueryOver Future Implementation: SetTimeout is not working. Query executes with default timeout.

[nhibernate-bot]

Alex V created an issue — 27th March 2013, 11:59:36:

Using QueryOver pattern setting timeout not working. e.g. query.RootCriteria.SetTimeout(x);
Consider the following example, none of the SetTimeout calls actually working, query executes with default timeout:

public IFutureValue<int> FutureCount<T>(QueryOver<T> query) 
    where T : PersistentObject
{
    query.RootCriteria.SetTimeout(900);
    query.UnderlyingCriteria.SetTimeout(900);
                
    var queryOver = query.GetExecutableQueryOver(session);
    queryOver.RootCriteria.SetTimeout(900);
    queryOver.UnderlyingCriteria.SetTimeout(900);
                
    var rowCountQuery = queryOver.ToRowCountQuery();
    rowCountQuery.RootCriteria.SetTimeout(900);
    rowCountQuery.UnderlyingCriteria.SetTimeout(900);

    return rowCountQuery.FutureValue<int>();
}

[hazzik]

This is not a bug per se. The feature just not implemented.

There are two concerns:

1. MultiCriteria (underlying component beneath Criteria/QueryOver Future) does not currently support timeouts (Add timeouts support to MultiCriteria #1403)
2. What timeout shall we use if a user has specified two different timeouts for different future queries?

[fredericDelaporte]

2. What timeout shall we use if a user has specified two different timeouts for different future queries?

The sum of them and of default timeouts for queries on which it was not specified! But for simplicity maybe just take the bigger. (And needs to take into account that 0 is the biggest, as it means "no timeout".)

[hazzik]

In most cases, this will mean "no timeout"/default timeout because if one of the queries do not specify timeout then "no timeout" wins.

[fredericDelaporte]

I do not understand the same thing. Not setting timeout and setting 0 is quite different: the former causes the use of the default timeout, while the later disables the timeout.