Skip to content

Commit 992ea06

Browse files
committed
Fix compiler warnings in BuilderTests
- Changed 'var newBuilder = self' to direct 'self' mutation - Since BaseBuilder is a class, we can mutate self directly - Removes 3 compiler warnings about unused mutable variables
1 parent 195527f commit 992ea06

File tree

1 file changed

+6
-10
lines changed

1 file changed

+6
-10
lines changed

Tests/DesignAlgorithmsKitTests/Creational/BuilderTests.swift

Lines changed: 6 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -21,15 +21,13 @@ final class BuilderTests: XCTestCase {
2121
private var property2: Int?
2222

2323
func setProperty1(_ value: String) -> Self {
24-
var newBuilder = self
25-
newBuilder.property1 = value
26-
return newBuilder
24+
self.property1 = value
25+
return self
2726
}
2827

2928
func setProperty2(_ value: Int) -> Self {
30-
var newBuilder = self
31-
newBuilder.property2 = value
32-
return newBuilder
29+
self.property2 = value
30+
return self
3331
}
3432

3533
override func build() throws -> TestObject {
@@ -86,10 +84,8 @@ final class BuilderTests: XCTestCase {
8684
private var value: Int?
8785

8886
func setValue(_ value: Int) -> Self {
89-
let builder = self
90-
var newBuilder = builder
91-
newBuilder.value = value
92-
return newBuilder
87+
self.value = value
88+
return self
9389
}
9490

9591
func validate() throws {

0 commit comments

Comments
 (0)