Skip to content

Commit ba47967

Browse files
Add version check for Firebird 5 in union tests
1 parent 44adff4 commit ba47967

File tree

2 files changed

+7
-2
lines changed

2 files changed

+7
-2
lines changed

src/FirebirdSql.EntityFrameworkCore.Firebird.FunctionalTests/Query/NorthwindSetOperationsQueryFbTest.cs

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@
1818
using System;
1919
using System.Threading.Tasks;
2020
using FirebirdSql.EntityFrameworkCore.Firebird.FunctionalTests.Helpers;
21+
using FirebirdSql.EntityFrameworkCore.Firebird.FunctionalTests.TestUtilities;
2122
using Microsoft.EntityFrameworkCore.Query;
2223
using Microsoft.EntityFrameworkCore.TestUtilities;
2324
using Xunit;
@@ -37,11 +38,13 @@ public override Task Union_Select_scalar(bool async)
3738
return base.Union_Select_scalar(async);
3839
}
3940

40-
// Not supported on FB 3 and 4
41-
[NotSupportedOnFirebirdTheory]
41+
[Theory]
4242
[MemberData(nameof(IsAsyncData))]
4343
public override Task Union_inside_Concat(bool async)
4444
{
45+
var fbTestStore = (FbTestStore)Fixture.TestStore;
46+
if (fbTestStore.ServerLessThan5())
47+
return Task.CompletedTask;
4548
return base.Union_inside_Concat(async);
4649
}
4750

src/FirebirdSql.EntityFrameworkCore.Firebird.FunctionalTests/TestUtilities/FbTestStore.cs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -43,6 +43,8 @@ public FbTestStore(string name, bool shared)
4343
public Version ServerVersion { get; private set; }
4444
public bool ServerLessThan4() => ServerVersion < new Version(4, 0, 0, 0);
4545

46+
public bool ServerLessThan5() => ServerVersion < new Version(5, 0, 0, 0);
47+
4648
protected override async Task InitializeAsync(Func<DbContext> createContext, Func<DbContext, Task> seed, Func<DbContext, Task> clean)
4749
{
4850
if (Connection.State != ConnectionState.Closed)

0 commit comments

Comments
 (0)