Fixed argument in range

Author: nigelhorne

Changes

@@ -1,5 +1,8 @@
 Revision history for Data-Random-String-Matches
 
+0.04
+	Fixed 'Argument "#" isn't numeric in range (or flop)' with qr/!#-'*+\\-\\.\\^_`|~0-9A-Za-z/
+
 0.03	Wed Oct 29 19:12:57 EDT 2025
 	Added some utility methods
 	Added the test dashboard

lib/Data/Random/String/Matches.pm

@@ -1033,9 +1033,8 @@ sub _random_from_class {
 	my @chars;
 
 	# Debugging this regex: qr/!#-'*+\\-\\.\\^_`|~0-9A-Za-z/
-	# which gives this error: 'Argument "#" isn't numeric in range (or flop)'
-	# DEBUG
-	warn "DEBUG: class = '$class', length = ", length($class);
+	# which used to give this error: 'Argument "#" isn't numeric in range (or flop)'
+	warn "DEBUG: class = '$class', length = ", length($class) if ($ENV{DEBUG_REGEX_GEN});
 
 	# Handle negation
 	my $negate = 0;
@@ -1049,13 +1048,12 @@ sub _random_from_class {
 	while ($i < length($class)) {
 		my $char = substr($class, $i, 1);
 
-		# DEBUG
-		warn "DEBUG: i=$i, char='$char' (ord=", ord($char), ')';
+		warn "DEBUG: i=$i, char='$char' (ord=", ord($char), ')' if ($ENV{DEBUG_REGEX_GEN});
 
 		if ($char eq '\\') {
 			$i++;
 			my $next = substr($class, $i, 1);
-			warn "DEBUG: Escaped char: $next";
+			warn "DEBUG: Escaped char: $next" if ($ENV{DEBUG_REGEX_GEN});
 			if ($next eq 'd') {
 				push @chars, ('0'..'9');
 			} elsif ($next eq 'w') {
@@ -1072,23 +1070,22 @@ sub _random_from_class {
 				# Escaped literal character (including \-, \., \^, etc.)
 				push @chars, $next;
 			}
-		} elsif ($i + 2 < length($class) && substr($class, $i+1, 1) eq '-' && substr($class, $i+2, 1) ne ']') {
-			# Range (but not if - is at end or before ])
-			my $next_char = substr($class, $i+1, 1);	# Potential range
+		} elsif ($i + 2 < length($class) && substr($class, $i+1, 1) eq '-') {
+			# Potential range
 			my $end_char = substr($class, $i+2, 1);
 
-			warn "DEBUG: Potential range: '$char' - '$end_char'";
-			
-			# Skip if end_char is a backslash (escaped char follows)
-			if ($end_char eq '\\') {
+			# Check if end is escaped or if this is valid range
+			if ($end_char eq '\\' || $end_char eq ']') {
+				# Not a range, dash is literal
 				push @chars, $char;
 			} elsif (ord($end_char) >= ord($char)) {
-				# Valid range
-				warn "DEBUG: Valid range from ", ord($char), ' to ', ord($end_char);
-				push @chars, ($char .. $end_char);
+				# Valid range - use ord/chr to avoid quote interpolation issues
+				my $start_ord = ord($char);
+				my $end_ord = ord($end_char);
+				push @chars, map { chr($_) } ($start_ord .. $end_ord);
 				$i += 2;  # Will be incremented again by loop, total +3
 			} else {
-				# Invalid range, treat as literals
+				# Invalid range order
 				push @chars, $char;
 			}
 		} else {
@@ -1097,7 +1094,7 @@ sub _random_from_class {
 		$i++;
 	}
 
-	warn 'DEBUG: Final chars array has ', scalar(@chars), ' elements';
+	warn 'DEBUG: Final chars array has ', scalar(@chars), ' elements' if ($ENV{DEBUG_REGEX_GEN});
 
 	if ($negate) {
 		my %excluded = map { $_ => 1 } @chars;