fixup(4328fbf),bypass(NIM-BUG): provide alt impl for Py_Hash for bytes by disallow setting when JS

Author: litlighilit

Objects/hash_def.nim

@@ -28,16 +28,26 @@ type PyHash_FuncDef* = object
   hash_bits*,
     seed_bits*: int
 
+const Py_SupHashBuffer* = not defined(js)  #XXX:NIM-BUG: js has bug to run hashData
+
 var PyHash_Func = PyHash_FuncDef(
     hash: hashData,
     name: ALGO,
     hash_bits: 64,
     seed_bits: 8*sizeof(int),
   )
 proc PyHash_GetFuncDef*: PyHash_FuncDef{.inline.} = PyHash_Func
-proc PyHash_SetFuncDef*(x: PyHash_FuncDef) = PyHash_Func = x
 
-proc Py_HashBuffer*(p: pointer, n: int): Hash{.raises: [].} = PyHash_Func.hash(p, n)
-proc Py_HashBuffer*[T](p: openArray[T]): Hash = Py_HashBuffer(p.addr0, p.len * sizeof T)
+when Py_SupHashBuffer:
+  proc PyHash_SetFuncDef*(x: PyHash_FuncDef) = PyHash_Func = x
+  proc Py_HashBuffer*(p: pointer, n: int): Hash{.raises: [].} = PyHash_Func.hash(p, n)
+  proc Py_HashBuffer*[T](p: openArray[T]): Hash = Py_HashBuffer(p.addr0, p.len * sizeof T)
+else:
+  const notSup = "set Py_HashBuffer is not supported in this platform"
+  proc PyHash_SetFuncDef*(x: PyHash_FuncDef){.error: notSup.}
+  proc Py_HashBuffer*(p: pointer, n: int): Hash{.raises: [], error: notSup.}
+  proc Py_HashBuffer*[T](p: openArray[T]): Hash =
+    for i in p:
+      result = result !& cast[int](i)
+    result = !$result
 
-const Py_SupHashBuffer* = not defined(js)

Objects/stringobject.nim

@@ -169,12 +169,7 @@ template itemSize*(self: UnicodeVariant): int =
 
 proc hashImpl(self: UnicodeVariant): Hash {. inline, cdecl .} = 
   template forLoop(ls): untyped =
-    when Py_SupHashBuffer:
-      Py_HashBuffer(ls.addr0, ls.len * self.itemSize)
-    else:
-      for i in ls:
-        result = result !& cast[int](i)
-      result = !$result
+    Py_HashBuffer(ls.addr0, ls.len * self.itemSize)
   if self.ascii:
     forLoop self.asciiStr
   else: