Skip to content

Commit 6062718

Browse files
committed
add a few more test cases
Signed-off-by: Aidan Jensen <aidandj.github@gmail.com>
1 parent a2f0e2d commit 6062718

File tree

2 files changed

+3
-0
lines changed

2 files changed

+3
-0
lines changed

proto/testproto/test.proto

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -181,6 +181,8 @@ message DeprecatedMessage {
181181

182182
optional string a_string = 1;
183183
optional string deprecated_field = 2 [deprecated = true];
184+
// This field is deprecated with comment
185+
optional string deprecated_field_with_comment = 3 [deprecated = true];
184186
}
185187

186188
message DeprecatedMessageBadComment {

stubtest_allowlist.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -257,3 +257,4 @@ testproto.grpc.dummy_pb2_grpc.EmptyServiceStub.__init__
257257
# Because we generate message fields as properties when deprecated they do not exist at runtime
258258
testproto.grpc.dummy_pb2.DeprecatedRequest.old_field
259259
testproto.test_pb2.DeprecatedMessage.deprecated_field
260+
testproto.test_pb2.DeprecatedMessage.deprecated_field_with_comment

0 commit comments

Comments
 (0)