Skip to content

Commit 06fc47a

Browse files
committed
service refactor
1 parent ad41be5 commit 06fc47a

File tree

2 files changed

+6
-4
lines changed

2 files changed

+6
-4
lines changed

src/main/java/upc/edu/gessi/repo/service/ReviewService.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
package upc.edu.gessi.repo.service;
22

33
import upc.edu.gessi.repo.dto.Review.ReviewDTO;
4-
import upc.edu.gessi.repo.dto.Review.ReviewFeatureDTO;
4+
import upc.edu.gessi.repo.dto.Review.ReviewFeatureResponseDTO;
55
import upc.edu.gessi.repo.exception.Reviews.NoReviewsFoundException;
66

77
import java.util.List;
@@ -15,6 +15,6 @@ public interface ReviewService extends CrudService<ReviewDTO> {
1515

1616
List<ReviewDTO> getByFeature(String feature);
1717

18-
List<ReviewFeatureDTO> getByFeatures(List<String> features) throws NoReviewsFoundException;
18+
List<ReviewFeatureResponseDTO> getByAppIdAndFeatures(String appId, List<String> features) throws NoReviewsFoundException;
1919

2020
}

src/main/java/upc/edu/gessi/repo/service/impl/ReviewServiceImpl.java

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -117,7 +117,9 @@ public List<ReviewDTO> getByFeature(String feature) {
117117
}
118118

119119
@Override
120-
public List<ReviewFeatureDTO> getByFeatures(List<String> features) throws NoReviewsFoundException {
121-
return ((ReviewRepository) useRepository(ReviewRepository.class)).findAllByFeatures(features);
120+
public List<ReviewFeatureResponseDTO> getByAppIdAndFeatures(String appId,
121+
List<String> features) throws NoReviewsFoundException {
122+
return ((ReviewRepository) useRepository(ReviewRepository.class))
123+
.findAllByAppIdAndFeatures(appId, features);
122124
}
123125
}

0 commit comments

Comments
 (0)