Plugin tries to download node.js artifact from project repositories

[jkrshw]

The gradle-node-plugin adds an ad-hoc ivy repository to download the node.js artifact. Due to how gradle artifact resolution works, gradle will try all repositories in the order they are defined when trying to resolve the node.js artifact.

In our case, we have a single internally hosted repository that proxies several public repositores as well as internal repositories. The request to our repository, that will always fail anyway, times out before returning a not found response, causing the grade build to occassionally fail.

Since the node.js artifact is unlikely to be in any of the project's repositories, and if it was, then baseDistUrl could be set to null to prevent the addition of the ad-hoc repository, it would make sense to specify the repository as exclusivly containing the org.nodejs:node artifact.

Similar configuration can be achieved in the build.gradle:

repositories{
  exclusiveContent {
    forRepository {
      ivy {
        name = "Node.js"
        url = "https://nodejs.org/dist/"
        patternLayout {
          artifact "v[revision]/[artifact](-v[revision]-[classifier]).[ext]"
        }
        metadataSources {
          artifact()
        }
      }
    }
    filter {
      includeModule "org.nodejs", "node"
    }
  }
}

[jkrshw]

I have added a pull request that I think could address the issue. I've never done gradle plugin development so i haven't been able to test it yet (either manually or with autoamted tests)

I'm happy to work on it more if this would be a helpful feature to add!

[deepy]

The only reason I can see not to do this is backwards compatibility, but since the next version will bump the requirements

I'll check more thoroughly tonight, but I think we probably want to change the default here and not give users any option to do differently
If they need to do it differently the documentation covers how to set up a repository of their own

[jkrshw]

Thanks for taking a look!

In terms of gradle compatibility the exclusive content feature has been in gradle since at least 6.6 which is the currently supported min version: https://docs.gradle.org/6.6/userguide/declaring_repositories.html#declaring_content_exclusively_found_in_one_repository

[deepy]

It's earlier than that, it's from 6.2 https://docs.gradle.org/6.2/release-notes.html#declaring-exclusive-repository-content