feat: report GraphQL error details

Preserve all GraphQL errors and render their structured data as JSON so
paths, locations, extensions, and additional errors remain visible in
command logs.

Assisted-by: codex:gpt-5.6-sol
Signed-off-by: Filip Skokan <panva.ip@gmail.com>

Author: panva

components/git/metadata.js

@@ -2,7 +2,7 @@ import { parsePRFromURL } from '../../lib/links.js';
 import { getMetadata } from '../metadata.js';
 import CLI from '../../lib/cli.js';
 import { getMergedConfig } from '../../lib/config.js';
-import { runPromise, IGNORE } from '../../lib/run.js';
+import { runPromise, reportError, IGNORE } from '../../lib/run.js';
 
 export const command = 'metadata <identifier>';
 export const describe =
@@ -67,7 +67,7 @@ export async function writeMetadataJsonResult(metadataPromise) {
     await writeStdout(`${JSON.stringify(json, null, 2)}\n`);
     process.exitCode = json.exitCode;
   } catch (error) {
-    console.error(error);
+    reportError(error);
     process.exitCode = 1;
   }
 }

lib/request.js

@@ -335,11 +335,12 @@ export default class Request {
     };
 
     const result = await this.json(url, options);
-    if (result.errors) {
+    if (result.errors?.length > 0) {
       const { type, message } = result.errors[0];
       const err = new Error(`[${type}] GraphQL request Error: ${message}`);
       err.data = {
-        variables
+        variables,
+        errors: result.errors
       };
       throw err;
     }

lib/run.js

@@ -8,6 +8,13 @@ import {
 
 export const IGNORE = '__ignore__';
 
+export function reportError(error, write = console.error) {
+  write(error?.stack ?? error);
+  if (error?.data !== undefined) {
+    write(JSON.stringify(error.data, null, 2));
+  }
+}
+
 function runAsyncBase(cmd, args, {
   ignoreFailure = true,
   spawnArgs,
@@ -72,7 +79,7 @@ export function forceRunAsync(cmd, args, options) {
   return runAsyncBase(cmd, args, options).catch((error) => {
     if (error.message !== IGNORE) {
       if (!error.messageOnly) {
-        console.error(error);
+        reportError(error);
       }
       throw error;
     }
@@ -82,7 +89,7 @@ export function forceRunAsync(cmd, args, options) {
 export function runPromise(promise) {
   return promise.catch((error) => {
     if (error.message !== IGNORE) {
-      console.error(error);
+      reportError(error);
     }
     exit();
   });

test/unit/request.test.js

@@ -0,0 +1,65 @@
+import { describe, it } from 'node:test';
+import assert from 'node:assert';
+
+import Request from '../../lib/request.js';
+
+function createRequest(response) {
+  const request = Object.create(Request.prototype);
+  request.credentials = { github: 'credentials' };
+  request.proxyAgent = undefined;
+  request.json = async() => response;
+  return request;
+}
+
+describe('Request', () => {
+  describe('query', () => {
+    it('preserves detailed GraphQL errors', async() => {
+      const variables = { owner: 'nodejs', repo: 'node', prid: 65130 };
+      const errors = [
+        {
+          type: 'FORBIDDEN',
+          path: [
+            'repository', 'pullRequest', 'commits', 'nodes', 0, 'commit',
+            'checkSuites', 'edges', 4, 'node', 'app'
+          ],
+          extensions: { saml_failure: false },
+          locations: [{ line: 26, column: 7 }],
+          message: 'Resource not accessible by integration'
+        },
+        {
+          type: 'FORBIDDEN',
+          path: ['repository', 'pullRequest', 'files'],
+          locations: [{ line: 42, column: 5 }],
+          message: 'A second error'
+        }
+      ];
+      const request = createRequest({ errors });
+
+      await assert.rejects(
+        request.query('query PR { pullRequest { id } }', variables),
+        (error) => {
+          assert.strictEqual(
+            error.message,
+            '[FORBIDDEN] GraphQL request Error: ' +
+              'Resource not accessible by integration');
+          assert.deepStrictEqual(error.data, { variables, errors });
+          return true;
+        });
+    });
+
+    it('preserves top-level GraphQL API errors', async() => {
+      const variables = { owner: 'nodejs', repo: 'node', prid: 65130 };
+      const request = createRequest({ message: 'Bad credentials' });
+
+      await assert.rejects(
+        request.query('query PR { pullRequest { id } }', variables),
+        (error) => {
+          assert.strictEqual(
+            error.message,
+            'GraphQL request Error: Bad credentials');
+          assert.deepStrictEqual(error.data, { variables });
+          return true;
+        });
+    });
+  });
+});

test/unit/run.test.js

@@ -0,0 +1,38 @@
+import { describe, it } from 'node:test';
+import assert from 'node:assert';
+
+import { reportError } from '../../lib/run.js';
+
+describe('reportError', () => {
+  it('renders structured error data as formatted JSON', () => {
+    const error = new Error(
+      '[FORBIDDEN] GraphQL request Error: Resource not accessible');
+    error.data = {
+      variables: { owner: 'nodejs', repo: 'node', prid: 65130 },
+      errors: [{
+        type: 'FORBIDDEN',
+        path: ['repository', 'pullRequest', 'checkSuites', 0, 'app'],
+        locations: [{ line: 26, column: 7 }],
+        extensions: { saml_failure: false },
+        message: 'Resource not accessible'
+      }]
+    };
+    const output = [];
+
+    reportError(error, (value) => output.push(value));
+
+    assert.deepStrictEqual(output, [
+      error.stack,
+      JSON.stringify(error.data, null, 2)
+    ]);
+  });
+
+  it('renders errors without structured data once', () => {
+    const error = new Error('boom');
+    const output = [];
+
+    reportError(error, (value) => output.push(value));
+
+    assert.deepStrictEqual(output, [error.stack]);
+  });
+});