stream: reorder stream/iter tests

Author: jasnell

test/parallel/test-stream-iter-broadcast-basic.js

@@ -229,6 +229,20 @@ async function testCancelWithFalsyReason() {
   assert.strictEqual(result, 0);
 }
 
+// Late-joining consumer should read from oldest buffered entry
+async function testLateJoinerSeesBufferedData() {
+  const { writer, broadcast: bc } = broadcast({ highWaterMark: 16 });
+
+  // Write data before any consumer joins
+  writer.writeSync('before-join');
+  writer.endSync();
+
+  // Consumer joins after data is written
+  const consumer = bc.push();
+  const result = await text(consumer);
+  assert.strictEqual(result, 'before-join');
+}
+
 Promise.all([
   testBasicBroadcast(),
   testMultipleWrites(),
@@ -244,17 +258,3 @@ Promise.all([
   testWriterFailIdempotent(),
   testLateJoinerSeesBufferedData(),
 ]).then(common.mustCall());
-
-// Late-joining consumer should read from oldest buffered entry
-async function testLateJoinerSeesBufferedData() {
-  const { writer, broadcast: bc } = broadcast({ highWaterMark: 16 });
-
-  // Write data before any consumer joins
-  writer.writeSync('before-join');
-  writer.endSync();
-
-  // Consumer joins after data is written
-  const consumer = bc.push();
-  const result = await text(consumer);
-  assert.strictEqual(result, 'before-join');
-}

test/parallel/test-stream-iter-pull-async.js

@@ -266,37 +266,6 @@ async function testPullTransformYieldsStrings() {
   assert.strictEqual(result, 'hello');
 }
 
-// Run the uncaughtException test sequentially (it installs a global handler
-// that would interfere with concurrent tests).
-(async () => {
-  await Promise.all([
-    testPullIdentity(),
-    testPullStatelessTransform(),
-    testPullStatefulTransform(),
-    testPullWithAbortSignal(),
-    testPullChainedTransforms(),
-    testPullSourceError(),
-    testTapCallbackError(),
-    testPullSignalAbortMidIteration(),
-    testPullConsumerBreakCleanup(),
-    testPullTransformReturnsPromise(),
-    testPullTransformYieldsStrings(),
-    testPullStatelessTransformError(),
-    testPullStatefulTransformError(),
-    testPullStatelessTransformFlush(),
-    testPullStatelessTransformFlushError(),
-    testPullWithSyncSource(),
-    testPullStringSource(),
-    testTransformReturnsSingleUint8Array(),
-    testTransformReturnsSingleString(),
-    testTransformReturnsArrayBuffer(),
-    testPipeToStringSource(),
-    testTransformOptionsNotShared(),
-  ]);
-  // Run after all concurrent tests complete to avoid global handler races
-  await testTransformSignalListenerErrorOnSourceError();
-})().then(common.mustCall());
-
 // pull() accepts a string source directly (normalized via from())
 async function testPullStringSource() {
   const data = await text(pull('hello-direct'));
@@ -369,3 +338,34 @@ async function testTransformOptionsNotShared() {
   // transform2 gets a fresh options object - no mutation visible
   assert.strictEqual(seen[1].mutated, undefined);
 }
+
+// Run the uncaughtException test sequentially (it installs a global handler
+// that would interfere with concurrent tests).
+(async () => {
+  await Promise.all([
+    testPullIdentity(),
+    testPullStatelessTransform(),
+    testPullStatefulTransform(),
+    testPullWithAbortSignal(),
+    testPullChainedTransforms(),
+    testPullSourceError(),
+    testTapCallbackError(),
+    testPullSignalAbortMidIteration(),
+    testPullConsumerBreakCleanup(),
+    testPullTransformReturnsPromise(),
+    testPullTransformYieldsStrings(),
+    testPullStatelessTransformError(),
+    testPullStatefulTransformError(),
+    testPullStatelessTransformFlush(),
+    testPullStatelessTransformFlushError(),
+    testPullWithSyncSource(),
+    testPullStringSource(),
+    testTransformReturnsSingleUint8Array(),
+    testTransformReturnsSingleString(),
+    testTransformReturnsArrayBuffer(),
+    testPipeToStringSource(),
+    testTransformOptionsNotShared(),
+  ]);
+  // Run after all concurrent tests complete to avoid global handler races
+  await testTransformSignalListenerErrorOnSourceError();
+})().then(common.mustCall());

test/parallel/test-stream-iter-push-writer.js

@@ -330,34 +330,6 @@ async function testEndRejectsPendingWrites() {
   for await (const _ of readable) { break; }
 }
 
-Promise.all([
-  testOndrain(),
-  testOndrainNonDrainable(),
-  testWriteWithSignalRejects(),
-  testWriteWithPreAbortedSignal(),
-  testCancelledWriteRemovedFromQueue(),
-  testOndrainResolvesFalseOnConsumerBreak(),
-  testOndrainRejectsOnConsumerThrow(),
-  testWritev(),
-  testWritevSync(),
-  testWritevMixedTypes(),
-  testWriteAfterEnd(),
-  testWriteAfterFail(),
-  testOndrainProtocolErrorPropagates(),
-  testFail(),
-  testEndAsyncReturnValue(),
-  testWriteUint8Array(),
-  testOndrainWaitsForDrain(),
-  testConsumerThrowRejectsWrites(),
-  testEndResolvesPendingRead(),
-  testFailRejectsPendingRead(),
-  testEndRejectsPendingWrites(),
-  testEndIdempotentWhenClosed(),
-  testEndRejectsWhenErrored(),
-  testAsyncDispose(),
-  testSyncDispose(),
-]).then(common.mustCall());
-
 async function testEndIdempotentWhenClosed() {
   const { writer, readable } = push({ highWaterMark: 10 });
   await writer.write('hello');
@@ -424,3 +396,31 @@ async function testEndRejectsWhenErrored() {
     // Expected - reader may see the error
   }
 }
+
+Promise.all([
+  testOndrain(),
+  testOndrainNonDrainable(),
+  testWriteWithSignalRejects(),
+  testWriteWithPreAbortedSignal(),
+  testCancelledWriteRemovedFromQueue(),
+  testOndrainResolvesFalseOnConsumerBreak(),
+  testOndrainRejectsOnConsumerThrow(),
+  testWritev(),
+  testWritevSync(),
+  testWritevMixedTypes(),
+  testWriteAfterEnd(),
+  testWriteAfterFail(),
+  testOndrainProtocolErrorPropagates(),
+  testFail(),
+  testEndAsyncReturnValue(),
+  testWriteUint8Array(),
+  testOndrainWaitsForDrain(),
+  testConsumerThrowRejectsWrites(),
+  testEndResolvesPendingRead(),
+  testFailRejectsPendingRead(),
+  testEndRejectsPendingWrites(),
+  testEndIdempotentWhenClosed(),
+  testEndRejectsWhenErrored(),
+  testAsyncDispose(),
+  testSyncDispose(),
+]).then(common.mustCall());

test/parallel/test-stream-iter-share-async.js

@@ -258,6 +258,13 @@ async function testShareMultipleConsumersConcurrentPull() {
   assert.strictEqual(t3, expected);
 }
 
+// share() accepts string source directly (normalized via from())
+async function testShareStringSource() {
+  const shared = share('hello-share');
+  const result = await text(shared.pull());
+  assert.strictEqual(result, 'hello-share');
+}
+
 Promise.all([
   testBasicShare(),
   testShareMultipleConsumers(),
@@ -273,10 +280,3 @@ Promise.all([
   testShareMultipleConsumersConcurrentPull(),
   testShareStringSource(),
 ]).then(common.mustCall());
-
-// share() accepts string source directly (normalized via from())
-async function testShareStringSource() {
-  const shared = share('hello-share');
-  const result = await text(shared.pull());
-  assert.strictEqual(result, 'hello-share');
-}

test/parallel/test-stream-iter-share-sync.js

@@ -144,6 +144,13 @@ function testShareSyncSourceError() {
   }, { message: 'sync share boom' });
 }
 
+// shareSync() accepts string source directly (normalized via fromSync())
+function testShareSyncStringSource() {
+  const shared = shareSync('hello-sync-share');
+  const result = textSync(shared.pull());
+  assert.strictEqual(result, 'hello-sync-share');
+}
+
 Promise.all([
   testShareSyncBasic(),
   testShareSyncMultipleConsumers(),
@@ -153,10 +160,3 @@ Promise.all([
   testShareSyncSourceError(),
   testShareSyncStringSource(),
 ]).then(common.mustCall());
-
-// shareSync() accepts string source directly (normalized via fromSync())
-function testShareSyncStringSource() {
-  const shared = shareSync('hello-sync-share');
-  const result = textSync(shared.pull());
-  assert.strictEqual(result, 'hello-sync-share');
-}