exclude AB from named param binding, move tests

Author: mike-git374

src/node_sqlite.cc

@@ -2161,7 +2161,8 @@ bool StatementSync::BindParams(const FunctionCallbackInfo<Value>& args) {
   int anon_idx = 1;
   int anon_start = 0;
 
-  if (args[0]->IsObject() && !args[0]->IsArrayBufferView()) {
+  if (args[0]->IsObject() && !args[0]->IsArrayBufferView() &&
+      !args[0]->IsArrayBuffer() && !args[0]->IsSharedArrayBuffer()) {
     Local<Object> obj = args[0].As<Object>();
     Local<Context> context = Isolate::GetCurrent()->GetCurrentContext();
     Local<Array> keys;

test/parallel/test-sqlite-data-types.js

@@ -80,19 +80,10 @@ suite('data binding and mapping', () => {
       text: '',
       buf: new Uint8Array(),
     });
-
-    const uint8Array = new Uint8Array([ 49, 50, 51, 52 ]);
-    const arrayBuffer = uint8Array.buffer;
-    t.assert.deepStrictEqual(
-      stmt.run(5, null, null, null, arrayBuffer),
-      { changes: 1, lastInsertRowid: 5 }
-    );
-    t.assert.deepStrictEqual(
-      query.get(5),
-      { __proto__: null, key: 5, int: null, double: null, text: null, buf: uint8Array }
-    );
   });
 
+
+
   test('large strings are bound correctly', (t) => {
     const db = new DatabaseSync(nextDb());
     t.after(() => { db.close(); });

test/parallel/test-sqlite-typed-array-and-data-view.js

@@ -14,6 +14,10 @@ function nextDb() {
 }
 
 const arrayBuffer = new Uint8Array([1, 2, 3, 4, 5, 6, 7, 8]).buffer;
+const sharedArrayBuffer = new SharedArrayBuffer(8);
+const typedArrayOnSharedArrayBuffer = new Uint8Array(sharedArrayBuffer);
+typedArrayOnSharedArrayBuffer.set([1, 2, 3, 4, 5, 6, 7, 8]);
+
 const TypedArrays = [
   ['Int8Array', Int8Array],
   ['Uint8Array', Uint8Array],
@@ -60,3 +64,68 @@ suite('StatementSync with TypedArray/DataView', () => {
     });
   }
 });
+
+suite('StatementSync with ArrayBuffer and SharedArrayBuffer', () => {
+  const buffers = [
+    ['ArrayBuffer', arrayBuffer],
+    ['SharedArrayBuffer', sharedArrayBuffer],
+  ];
+
+  for (const [displayName, buffer] of buffers) {
+    test(`${displayName} - anonymous binding`, (t) => {
+      const db = new DatabaseSync(nextDb());
+      t.after(() => { db.close(); });
+      db.exec('CREATE TABLE test (data BLOB)');
+      // insert
+      {
+        const stmt = db.prepare('INSERT INTO test VALUES (?)');
+        stmt.run(buffer);
+      }
+      // select all
+      {
+        const stmt = db.prepare('SELECT * FROM test');
+        const row = stmt.get();
+        t.assert.ok(row.data instanceof Uint8Array);
+        t.assert.strictEqual(row.data.length, 8);
+        t.assert.deepStrictEqual(row.data, new Uint8Array(arrayBuffer));
+      }
+      // query
+      {
+        const stmt = db.prepare('SELECT * FROM test WHERE data = ?');
+        const rows = stmt.all(buffer);
+        t.assert.strictEqual(rows.length, 1);
+        t.assert.ok(rows[0].data instanceof Uint8Array);
+        t.assert.strictEqual(rows[0].data.length, 8);
+        t.assert.deepStrictEqual(rows[0].data, new Uint8Array(arrayBuffer));
+      }
+    });
+
+    test(`${displayName} - named binding (object)`, (t) => {
+      const db = new DatabaseSync(nextDb());
+      t.after(() => { db.close(); });
+      db.exec('CREATE TABLE test (data BLOB)');
+      // insert
+      {
+        const stmt = db.prepare('INSERT INTO test VALUES ($data)');
+        stmt.run({ '$data': buffer });
+      }
+      // select all
+      {
+        const stmt = db.prepare('SELECT * FROM test');
+        const row = stmt.get();
+        t.assert.ok(row.data instanceof Uint8Array);
+        t.assert.strictEqual(row.data.length, 8);
+        t.assert.deepStrictEqual(row.data, new Uint8Array(arrayBuffer));
+      }
+      // query
+      {
+        const stmt = db.prepare('SELECT * FROM test WHERE data = $data');
+        const rows = stmt.all({ '$data': buffer });
+        t.assert.strictEqual(rows.length, 1);
+        t.assert.ok(rows[0].data instanceof Uint8Array);
+        t.assert.strictEqual(rows[0].data.length, 8);
+        t.assert.deepStrictEqual(rows[0].data, new Uint8Array(arrayBuffer));
+      }
+    });
+  }
+});