test_runner: add context subtests expectFailure only skip todo

Co-Authored-By: Heath Dutton🕴️ <heathdutton@linux.com>
Co-Authored-By: Felipe <60716370+felipeness@users.noreply.github.com>

Author: 3 people

lib/internal/test_runner/test.js

@@ -14,6 +14,7 @@ const {
   MathMax,
   Number,
   NumberPrototypeToFixed,
+  ObjectAssign,
   ObjectKeys,
   ObjectSeal,
   Promise,
@@ -358,11 +359,11 @@ class TestContext {
     this.#test.todo(message);
   }
 
-  test(name, options, fn) {
-    const overrides = {
+  #runTest(name, options, fn, extraOverrides) {
+    const overrides = ObjectAssign({
       __proto__: null,
       loc: getCallerLocation(),
-    };
+    }, extraOverrides);
 
     const { plan } = this.#test;
     if (plan !== null) {
@@ -377,6 +378,14 @@ class TestContext {
     return subtest.start();
   }
 
+  test = ObjectAssign((...args) => this.#runTest(...args), {
+    __proto__: null,
+    expectFailure: (name, opts, fn) => this.#runTest(name, opts, fn, { __proto__: null, expectFailure: true }),
+    only: (name, opts, fn) => this.#runTest(name, opts, fn, { __proto__: null, only: true }),
+    skip: (name, opts, fn) => this.#runTest(name, opts, fn, { __proto__: null, skip: true }),
+    todo: (name, opts, fn) => this.#runTest(name, opts, fn, { __proto__: null, todo: true }),
+  });
+
   before(fn, options) {
     this.#test.createHook('before', fn, {
       __proto__: null,

test/parallel/test-runner-subtest-methods.js

@@ -0,0 +1,53 @@
+'use strict';
+
+require('../common');
+const assert = require('node:assert');
+const { test } = require('node:test');
+const { isPromise } = require('node:util/types');
+
+test('subtest context should have test variants', async (t) => {
+  assert.strictEqual(typeof t.test, 'function');
+  assert.strictEqual(typeof t.test.expectFailure, 'function');
+  assert.strictEqual(typeof t.test.only, 'function');
+  assert.strictEqual(typeof t.test.skip, 'function');
+  assert.strictEqual(typeof t.test.todo, 'function');
+});
+
+test('subtest should return a promise', async (t) => {
+  const normal = t.test('normal subtest');
+  assert.ok(isPromise(normal));
+  await normal;
+});
+
+test('t.test[variant]() should return a promise', async (t) => {
+  assert.ok(isPromise(
+    t.test.expectFailure('expectFailure subtest', () => { throw new Error('This should pass'); })
+  ));
+  assert.ok(isPromise(
+    t.test.only('only subtest')
+  ));
+  assert.ok(isPromise(
+    t.test.skip('skip subtest')
+  ));
+  assert.ok(isPromise(
+    t.test.todo('todo subtest')
+  ));
+});
+
+test('nested subtests should have test variants', async (t) => {
+  await t.test('level 1', async (t) => {
+    assert.strictEqual(typeof t.test, 'function');
+    assert.strictEqual(typeof t.test.expectFailure, 'function');
+    assert.strictEqual(typeof t.test.only, 'function');
+    assert.strictEqual(typeof t.test.skip, 'function');
+    assert.strictEqual(typeof t.test.todo, 'function');
+
+    await t.test('level 2', async (t) => {
+      assert.strictEqual(typeof t.test, 'function');
+      assert.strictEqual(typeof t.test.expectFailure, 'function');
+      assert.strictEqual(typeof t.test.skip, 'function');
+      assert.strictEqual(typeof t.test.todo, 'function');
+      assert.strictEqual(typeof t.test.only, 'function');
+    });
+  });
+});