fixup! quic: extract transport logic from Application to Session

Convert fin to bool

Author: pimterry

src/quic/application.cc

@@ -339,7 +339,7 @@ class DefaultApplication final : public Session::Application {
     // Reset the state of stream_data before proceeding...
     stream_data->id = -1;
     stream_data->count = 0;
-    stream_data->fin = 0;
+    stream_data->fin = false;
     stream_data->stream.reset();
     Debug(&session(), "Default application getting stream data");
     DCHECK_NOT_NULL(stream_data);
@@ -362,7 +362,7 @@ class DefaultApplication final : public Session::Application {
             case bob::Status::STATUS_WAIT:
               return;
             case bob::Status::STATUS_EOS:
-              stream_data->fin = 1;
+              stream_data->fin = true;
           }
 
           // It is possible that the data pointers returned are not actually
@@ -393,10 +393,10 @@ class DefaultApplication final : public Session::Application {
                              arraysize(stream_data->data),
                              kMaxVectorCount);
       if (ret == bob::Status::STATUS_EOS) {
-        stream_data->fin = 1;
+        stream_data->fin = true;
       }
     } else {
-      stream_data->fin = 1;
+      stream_data->fin = true;
     }
 
     return 0;

src/quic/http3.cc

@@ -680,16 +680,19 @@ class Http3ApplicationImpl final : public Session::Application {
     ssize_t ret = 0;
     Debug(&session(), "HTTP/3 application getting stream data");
     if (conn_ && session().max_data_left()) {
+      // nghttp3 reports fin through an int out-param; bridge it to the bool.
+      int fin = 0;
       ret =
           nghttp3_conn_writev_stream(*this,
                                      &data->id,
-                                     &data->fin,
+                                     &fin,
                                      reinterpret_cast<nghttp3_vec*>(data->data),
                                      data->count);
       // A negative return value indicates an error.
       if (ret < 0) {
         return static_cast<int>(ret);
       }
+      data->fin = fin != 0;
 
       data->count = static_cast<size_t>(ret);
       if (data->id >= 0 && data->id != control_stream_id_ &&

src/quic/session.h

@@ -113,7 +113,7 @@ class Session final : public AsyncWrap, private SessionTicket::AppData::Source {
     // The stream identifier. If this is a negative value then no stream is
     // identified.
     stream_id id = -1;
-    int fin = 0;
+    bool fin = false;
     ngtcp2_vec data[kMaxVectorCount]{};
     BaseObjectPtr<Stream> stream;