fix: replace deprecated waitFor (resolves: #63)

Author: pimlie

src/browsers/puppeteer/webpage.js

@@ -10,7 +10,14 @@ export default class PuppeteerWebpage extends Webpage {
     await this.page.goto(url)
 
     if (readyCondition) {
-      await this.page.waitFor(readyCondition)
+      let waitFn = 'waitForSelector'
+      if (typeof readyCondition === 'number') {
+        waitFn = 'waitForTimeout'
+      }  else if (typeof readyCondition === 'function') {
+        waitFn = 'waitForFunction'
+      }
+    
+      await this.page[waitFn](readyCondition)
     }
 
     return this.returnProxy()

test/unit/webpage.puppeteer.test.js

@@ -14,6 +14,7 @@ describe('puppeteer/webpage', () => {
         return Promise.resolve({
           goto: (...args) => spy('goto', ...args),
           waitFor: (...args) => spy('waitFor', ...args),
+          waitForSelector: (...args) => spy('waitForSelector', ...args),
           evaluate: (...args) => spy('evaluate', ...args),
           title: (...args) => spy('title', ...args)
         })
@@ -27,7 +28,8 @@ describe('puppeteer/webpage', () => {
     const webPath = '/'
     webpage = await browser.page(webPath)
     expect(spy).toHaveBeenCalledWith('goto', webPath)
-    expect(spy).toHaveBeenCalledWith('waitFor', 'body')
+    expect(spy).toHaveBeenCalledWith('waitForSelector', 'body')
+    expect(spy).not.toHaveBeenCalledWith('waitFor')
   })
 
   test('should implement getHtml', () => {