Skip to content

Commit 59f4b9a

Browse files
committed
Move Skill Categories link from menu to button on Skills page, update snapshot tests
1 parent cbf4b86 commit 59f4b9a

File tree

7 files changed

+72
-8
lines changed

7 files changed

+72
-8
lines changed

web-ui/src/components/edit_skills/EditSkillsCard.test.js

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@ import EditSkillsPage from "../../pages/EditSkillsPage";
44
import { AppContextProvider } from "../../context/AppContext";
55
import { rest } from "msw";
66
import { setupServer } from "msw/node";
7+
import {BrowserRouter} from "react-router-dom";
78

89
const initialState = {
910
state: {
@@ -56,7 +57,9 @@ it("renders correctly", () => {
5657
it("renders correctly", () => {
5758
snapshot(
5859
<AppContextProvider value={initialState}>
59-
<EditSkillsPage />
60+
<BrowserRouter>
61+
<EditSkillsPage />
62+
</BrowserRouter>
6063
</AppContextProvider>
6164
);
6265
});

web-ui/src/components/edit_skills/__snapshots__/EditSkillsCard.test.js.snap

Lines changed: 29 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -797,7 +797,7 @@ label[data-shrink=false]+.MuiInputBase-formControl .emotion-3:focus::-ms-input-p
797797
</div>
798798
</div>
799799
<div
800-
className="combine-skills"
800+
className="skill-actions-container"
801801
>
802802
<button
803803
className="MuiButton-root MuiButton-text MuiButton-textPrimary MuiButton-sizeMedium MuiButton-textSizeMedium MuiButtonBase-root emotion-6"
@@ -823,6 +823,34 @@ label[data-shrink=false]+.MuiInputBase-formControl .emotion-3:focus::-ms-input-p
823823
className="MuiTouchRipple-root emotion-7"
824824
/>
825825
</button>
826+
<a
827+
href="/admin/skill-categories"
828+
onClick={[Function]}
829+
>
830+
<button
831+
className="MuiButton-root MuiButton-text MuiButton-textPrimary MuiButton-sizeMedium MuiButton-textSizeMedium MuiButtonBase-root emotion-6"
832+
disabled={false}
833+
onBlur={[Function]}
834+
onContextMenu={[Function]}
835+
onDragLeave={[Function]}
836+
onFocus={[Function]}
837+
onKeyDown={[Function]}
838+
onKeyUp={[Function]}
839+
onMouseDown={[Function]}
840+
onMouseLeave={[Function]}
841+
onMouseUp={[Function]}
842+
onTouchEnd={[Function]}
843+
onTouchMove={[Function]}
844+
onTouchStart={[Function]}
845+
tabIndex={0}
846+
type="button"
847+
>
848+
Categorize Skills
849+
<span
850+
className="MuiTouchRipple-root emotion-7"
851+
/>
852+
</button>
853+
</a>
826854
</div>
827855
</div>
828856
<div

web-ui/src/components/menu/Menu.jsx

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -100,7 +100,6 @@ const adminLinks = [
100100
["/admin/users", "Users"],
101101
["/admin/email", "Send Email"],
102102
["/admin/edit-skills", "Skills"],
103-
["/admin/skill-categories", "Skill Categories"],
104103
];
105104

106105
const directoryLinks = [

web-ui/src/pages/EditSkillsPage.css

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,10 +6,11 @@
66
margin: 1rem;
77
}
88

9-
.combine-skills {
9+
.skill-actions-container {
1010
align-items: center;
1111
display: flex;
1212
justify-content: flex-end;
13+
gap: 1rem;
1314
}
1415

1516
.search {
@@ -18,6 +19,7 @@
1819
align-items: center;
1920
margin-left: 1rem;
2021
margin-right: 1rem;
22+
flex-wrap: wrap;
2123
}
2224

2325
.show-all-skills {

web-ui/src/pages/EditSkillsPage.jsx

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,12 +4,13 @@ import { AppContext } from "../context/AppContext";
44
import { selectOrderedSkills, selectPendingSkills } from "../context/selectors";
55
import EditSkillsCard from "../components/edit_skills/EditSkillsCard";
66
import EditSkillsModal from "../components/edit_skills/EditSkillsModal";
7+
import {Link} from "react-router-dom";
78

89
import { Button, TextField } from "@mui/material";
910

1011
import "./EditSkillsPage.css";
1112

12-
const EditSkillsPage = (props) => {
13+
const EditSkillsPage = () => {
1314
const { state } = useContext(AppContext);
1415

1516
const [searchText, setSearchText] = useState("");
@@ -48,8 +49,11 @@ const EditSkillsPage = (props) => {
4849
/>
4950
</div>
5051
</div>
51-
<div className="combine-skills">
52+
<div className="skill-actions-container">
5253
<Button onClick={handleOpen}>Combine Skills</Button>
54+
<Link to="/admin/skill-categories">
55+
<Button>Categorize Skills</Button>
56+
</Link>
5357
</div>
5458
</div>
5559

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,14 @@
11
import React from "react";
22
import EditSkillsPage from "./EditSkillsPage";
33
import { AppContextProvider } from "../context/AppContext";
4+
import {BrowserRouter} from "react-router-dom";
45

56
it("renders correctly", () => {
67
snapshot(
78
<AppContextProvider>
8-
<EditSkillsPage />
9+
<BrowserRouter>
10+
<EditSkillsPage />
11+
</BrowserRouter>
912
</AppContextProvider>
1013
);
1114
});

web-ui/src/pages/__snapshots__/EditSkillsPage.test.js.snap

Lines changed: 26 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -403,7 +403,7 @@ label[data-shrink=false]+.MuiInputBase-formControl .emotion-3:focus::-ms-input-p
403403
</div>
404404
</div>
405405
<div
406-
className="combine-skills"
406+
className="skill-actions-container"
407407
>
408408
<button
409409
className="MuiButton-root MuiButton-text MuiButton-textPrimary MuiButton-sizeMedium MuiButton-textSizeMedium MuiButtonBase-root emotion-6"
@@ -426,6 +426,31 @@ label[data-shrink=false]+.MuiInputBase-formControl .emotion-3:focus::-ms-input-p
426426
>
427427
Combine Skills
428428
</button>
429+
<a
430+
href="/admin/skill-categories"
431+
onClick={[Function]}
432+
>
433+
<button
434+
className="MuiButton-root MuiButton-text MuiButton-textPrimary MuiButton-sizeMedium MuiButton-textSizeMedium MuiButtonBase-root emotion-6"
435+
disabled={false}
436+
onBlur={[Function]}
437+
onContextMenu={[Function]}
438+
onDragLeave={[Function]}
439+
onFocus={[Function]}
440+
onKeyDown={[Function]}
441+
onKeyUp={[Function]}
442+
onMouseDown={[Function]}
443+
onMouseLeave={[Function]}
444+
onMouseUp={[Function]}
445+
onTouchEnd={[Function]}
446+
onTouchMove={[Function]}
447+
onTouchStart={[Function]}
448+
tabIndex={0}
449+
type="button"
450+
>
451+
Categorize Skills
452+
</button>
453+
</a>
429454
</div>
430455
</div>
431456
<div

0 commit comments

Comments
 (0)