Do not record executable path in action

Signed-off-by: Marek Kubica <marek@tarides.com>

Author: Leonidas-from-XIV

src/dune_rules/pkg_rules.ml

@@ -986,14 +986,12 @@ module Action_expander = struct
                | Path p | Dir p -> Path p))
          in
          let ocamlfind_destdir = (Lazy.force expander.paths.install_roots).lib_root in
-         let dune_exe = Path.of_string Sys.executable_name in
          Run_with_path.action
            ~depexts
            ~pkg:(expander.name, prog_loc)
            exe
            args
-           ~ocamlfind_destdir
-           ~dune_exe)
+           ~ocamlfind_destdir)
     | Progn t ->
       let+ args = Memo.parallel_map t ~f:(expand ~expander) in
       Action.Progn args

src/dune_rules/run_with_path.ml

@@ -84,7 +84,6 @@ module Spec = struct
     { prog : ('path, Action.Prog.Not_found.t) result
     ; args : 'path arg Array.Immutable.t
     ; ocamlfind_destdir : 'path
-    ; dune_exe : 'path
     ; pkg : Dune_pkg.Package_name.t * Loc.t
     ; depexts : string list
     }
@@ -102,16 +101,13 @@ module Spec = struct
     { t with
       args = Array.Immutable.map t.args ~f:(map_arg ~f)
     ; ocamlfind_destdir = f t.ocamlfind_destdir
-    ; dune_exe = f t.dune_exe
     ; prog = Result.map t.prog ~f
     }
   ;;
 
   let is_useful_to ~memoize:_ = true
 
-  let encode { prog; args; ocamlfind_destdir; dune_exe; pkg = _; depexts = _ } path _
-    : Sexp.t
-    =
+  let encode { prog; args; ocamlfind_destdir; pkg = _; depexts = _ } path _ : Sexp.t =
     let prog : Sexp.t =
       match prog with
       | Ok p -> path p
@@ -124,11 +120,11 @@ module Spec = struct
              | String s -> Sexp.Atom s
              | Path p -> path p)))
     in
-    List [ List ([ prog ] @ args); path ocamlfind_destdir; path dune_exe ]
+    List [ List ([ prog ] @ args); path ocamlfind_destdir ]
   ;;
 
   let action
-        { prog; args; ocamlfind_destdir; dune_exe; pkg; depexts }
+        { prog; args; ocamlfind_destdir; pkg; depexts }
         ~(ectx : Action.context)
         ~(eenv : Action.env)
     =
@@ -147,8 +143,9 @@ module Spec = struct
       let metadata = Process.create_metadata ~purpose:ectx.metadata.purpose () in
       let dune_folder =
         let bin_folder = Temp.create Dir ~prefix:"dune" ~suffix:"self-in-path" in
+        let src = Path.of_string Sys.executable_name in
         let dst = Path.relative bin_folder "dune" in
-        Io.portable_symlink ~src:dune_exe ~dst;
+        Io.portable_symlink ~src ~dst;
         Path.to_string bin_folder
       in
       let env =
@@ -191,6 +188,6 @@ end
 
 module A = Action_ext.Make (Spec)
 
-let action ~pkg ~depexts prog args ~ocamlfind_destdir ~dune_exe =
-  A.action { Spec.prog; args; ocamlfind_destdir; dune_exe; pkg; depexts }
+let action ~pkg ~depexts prog args ~ocamlfind_destdir =
+  A.action { Spec.prog; args; ocamlfind_destdir; pkg; depexts }
 ;;

src/dune_rules/run_with_path.mli

@@ -20,5 +20,4 @@ val action
   -> Action.Prog.t
   -> Path.t Spec.arg Array.Immutable.t
   -> ocamlfind_destdir:Path.t
-  -> dune_exe:Path.t
   -> Action.t