Skip to content

Conversation

Copy link

Copilot AI commented Dec 5, 2025

Addresses 4 critical bugs affecting security, internationalization, and UI compatibility across multiple extensions.

Changes

spotifyBackup: Prevent GitHub PAT auto-revocation (#52)

GitHub scans all gists and auto-revokes PATs found in content. Sanitize backup data before upload:

function sanitizeBackupData() {
    const data = { ...localStorage };
    const settings = JSON.parse(data["spotifyBackup:settings"]);
    delete settings.gistToken;  // Exclude from gist upload
    return data;
}

Preserve current token during restore by reading from localStorage post-restoration instead of re-parsing backup.

npvAmbience: Language-independent selectors (#49)

Replace hardcoded English aria-label selectors with structural selectors:

// Before: aside[aria-label="Now playing view"]
// After:  .Root__right-sidebar aside

playbarClock: Remove button background artifact (#33)

Explicitly set backgroundColor: "transparent" on clock button to prevent theme bleed-through.

sleepTimer: Multi-version DOM selector fallbacks (#32)

Add fallback selectors for Spotify UI changes:

nowPlayingWidget = document.querySelector(".main-nowPlayingWidget-nowPlaying") 
    || document.querySelector(".main-nowPlayingBar-left");

All changes use Object.prototype.hasOwnProperty.call() for safer property checks.

Original prompt

create me a pr fixing all current issues


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Copilot AI and others added 4 commits December 5, 2025 13:20
…vocation

Co-authored-by: ohitstom <22730962+ohitstom@users.noreply.github.com>
…ebar

Co-authored-by: ohitstom <22730962+ohitstom@users.noreply.github.com>
…ibility

Co-authored-by: ohitstom <22730962+ohitstom@users.noreply.github.com>
Co-authored-by: ohitstom <22730962+ohitstom@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix all current issues in the project Fix PAT exposure, i18n selectors, and UI compatibility issues Dec 5, 2025
Copilot AI requested a review from ohitstom December 5, 2025 13:28
Copilot finished work on behalf of ohitstom December 5, 2025 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants