Use accessors (new, get, set) instead of direct field access#152
Merged
Conversation
Signed-off-by: Arrobo, Gabriel <gabriel.arrobo@intel.com>
There was a problem hiding this comment.
Pull request overview
This PR updates Go code to rely on generated model constructors/setters (instead of struct literals/direct field assignment) and modernizes heap interface method signatures to use any.
Changes:
- Update
NfProfilePriorityQheap-related method signatures frominterface{}toany. - Refactor AMF profile test setup to use
models.NewNFProfileDiscovery(...)plus setter methods, and adjust theMatchAmfProfilecall to pass a pointer.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| nrfcache/nrfcache.go | Switch heap/queue method signatures to any (Go 1.18+ alias) for consistency with modern Go typing. |
| nrfcache/nrfcache_test.go | Use generated constructor and setters for NFProfileDiscovery in AMF matching tests; pass the profile pointer to MatchAmfProfile. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
sureshmarikkannu
previously approved these changes
Jun 6, 2026
Signed-off-by: Arrobo, Gabriel <gabriel.arrobo@intel.com>
sureshmarikkannu
approved these changes
Jun 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.