Skip to content

Add P-CSCF support for IMS#153

Merged
gab-arrobo merged 2 commits into
omec-project:mainfrom
gab-arrobo:add-pcscf-support
Jun 6, 2026
Merged

Add P-CSCF support for IMS#153
gab-arrobo merged 2 commits into
omec-project:mainfrom
gab-arrobo:add-pcscf-support

Conversation

@gab-arrobo

Copy link
Copy Markdown
Contributor

Rebuild models/apis/utils from standard templates and create minor release

Signed-off-by: Arrobo, Gabriel <gabriel.arrobo@intel.com>

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the nfConfigApi OpenAPI surface to add P-CSCF IPv4 support (IMS), then regenerates the nfConfigApi Go client/models using newer standard templates/shared helpers, and bumps the release version to 2.1.0.

Changes:

  • Bump project version from 2.0.1-dev to 2.1.0.
  • Extend IpDomain with optional pcscfIpv4 in the OpenAPI spec and generated Go model.
  • Regenerate nfConfigApi client/models to use shared github.com/omec-project/openapi/v2 helpers, add AdditionalProperties support, and clean up template assets/docs.

Reviewed changes

Copilot reviewed 8 out of 32 changed files in this pull request and generated 13 comments.

Show a summary per file
File Description
VERSION Bumps release version to 2.1.0.
nfConfigApi/webconsole-api.yaml Adds pcscfIpv4 to IpDomain schema.
nfConfigApi/utils.go Updates generated helpers (adds NullableAny, exports NewStrictDecoder, shifts away from local reportError).
nfConfigApi/README.md Removes nfConfigApi regeneration documentation.
nfConfigApi/openapi-generator-cli-templates/README.mustache Removes custom README template.
nfConfigApi/openapi-generator-cli-templates/partial_header.mustache Removes custom header template.
nfConfigApi/openapi-generator-cli-templates/api.mustache.license Removes template license metadata file.
nfConfigApi/openapi-generator-cli-templates/api.mustache Removes custom API template (moves to standard templates).
nfConfigApi/model_upf.go Regenerated model (YAML tags, AdditionalProperties, shared openapi helpers).
nfConfigApi/model_status.go Regenerated enum validation using slices.Contains + shared openapi.ReportError.
nfConfigApi/model_snssai.go Regenerated model (YAML tags, AdditionalProperties, shared openapi helpers).
nfConfigApi/model_session_management.go Regenerated model (YAML tags, AdditionalProperties, shared openapi helpers).
nfConfigApi/model_preempt_vuln.go Regenerated enum validation using slices.Contains + shared openapi.ReportError.
nfConfigApi/model_preempt_cap.go Regenerated enum validation using slices.Contains + shared openapi.ReportError.
nfConfigApi/model_policy_control.go Regenerated model (YAML tags, AdditionalProperties, shared openapi helpers).
nfConfigApi/model_plmn_snssai.go Regenerated model (YAML tags, AdditionalProperties, shared openapi helpers).
nfConfigApi/model_plmn_id.go Regenerated model (YAML tags, AdditionalProperties, shared openapi helpers).
nfConfigApi/model_pcc_rule.go Regenerated model (YAML tags, AdditionalProperties, shared openapi helpers).
nfConfigApi/model_pcc_qos.go Regenerated model (YAML tags, AdditionalProperties, shared openapi helpers).
nfConfigApi/model_pcc_flow.go Regenerated model (YAML tags, AdditionalProperties, shared openapi helpers).
nfConfigApi/model_ip_domain.go Adds PcscfIpv4 field to generated model + AdditionalProperties.
nfConfigApi/model_imsi_qos.go Regenerated model (YAML tags, AdditionalProperties, shared openapi helpers).
nfConfigApi/model_direction.go Regenerated enum validation using slices.Contains + shared openapi.ReportError.
nfConfigApi/model_arp.go Regenerated model (YAML tags, AdditionalProperties, shared openapi helpers).
nfConfigApi/model_access_and_mobility.go Regenerated model (YAML tags, AdditionalProperties, shared openapi helpers).
nfConfigApi/configuration.go Updates client defaults (User-Agent, string replacement, shared error helper).
nfConfigApi/client.go Switches to shared openapi helpers for encoding/decoding + updated multipart handling/logging.
nfConfigApi/api_default.go Regenerated API layer to use shared openapi helpers and interface-based service wiring.
models/model_traffic_influ_data.go Minor comment whitespace cleanup.
models/model_traffic_correlation_info.go Minor comment whitespace cleanup.
models/model_data_ind.go Minor comment whitespace cleanup.
models/model_am_influ_data.go Minor comment whitespace cleanup.
Files not reviewed (20)
  • nfConfigApi/api_default.go: Language not supported
  • nfConfigApi/client.go: Language not supported
  • nfConfigApi/configuration.go: Language not supported
  • nfConfigApi/model_access_and_mobility.go: Language not supported
  • nfConfigApi/model_arp.go: Language not supported
  • nfConfigApi/model_direction.go: Language not supported
  • nfConfigApi/model_imsi_qos.go: Language not supported
  • nfConfigApi/model_ip_domain.go: Language not supported
  • nfConfigApi/model_pcc_flow.go: Language not supported
  • nfConfigApi/model_pcc_qos.go: Language not supported
  • nfConfigApi/model_pcc_rule.go: Language not supported
  • nfConfigApi/model_plmn_id.go: Language not supported
  • nfConfigApi/model_plmn_snssai.go: Language not supported
  • nfConfigApi/model_policy_control.go: Language not supported
  • nfConfigApi/model_preempt_cap.go: Language not supported
  • nfConfigApi/model_preempt_vuln.go: Language not supported
  • nfConfigApi/model_session_management.go: Language not supported
  • nfConfigApi/model_snssai.go: Language not supported
  • nfConfigApi/model_status.go: Language not supported
  • nfConfigApi/model_upf.go: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread nfConfigApi/model_access_and_mobility.go Outdated
Comment thread nfConfigApi/model_arp.go
Comment thread nfConfigApi/model_imsi_qos.go Outdated
Comment thread nfConfigApi/model_ip_domain.go Outdated
Comment thread nfConfigApi/model_pcc_flow.go
Comment thread nfConfigApi/model_plmn_snssai.go
Comment thread nfConfigApi/model_policy_control.go Outdated
Comment thread nfConfigApi/model_session_management.go Outdated
Comment thread nfConfigApi/model_snssai.go Outdated
Comment thread nfConfigApi/model_upf.go Outdated
Signed-off-by: Arrobo, Gabriel <gabriel.arrobo@intel.com>
@gab-arrobo gab-arrobo merged commit c18ff15 into omec-project:main Jun 6, 2026
9 checks passed
@gab-arrobo gab-arrobo deleted the add-pcscf-support branch June 6, 2026 05:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants