Feat/improve io docs #136

ellispinsky · 2025-12-04T23:34:45Z

Description

Please provide an explanation of the changes you've made:

[Describe what this PR does and why]

Implementation Checklist

If updating our sample apps, update the info in our Quickstart
If updating our CLI, update the info in our CLI

Testing

mintlify dev works (see installation here)

Docs

Link to a PR in our docs repo documenting your change (if applicable)

Visual Proof

Please provide a screenshot or video demonstrating that your changes work locally:

[Drag and drop your screenshot/video here or use the following format:]
[]

Related Issue

Fixes [Github issue link]

[If this corresponds to a fix from another Kernel OSS repo, include this:]

Fixes [Link to other repo]

[Replace with actual issue link, e.g., Fixes https://github.com/username/repo/issues/123]

Additional Notes

[Any additional context, concerns, or notes for reviewers]

mesa-dot-dev · 2025-12-04T23:35:40Z

Mesa Description

Description

Please provide an explanation of the changes you've made:

This PR improves the documentation for file I/O operations in browsers/file-io.mdx. It updates and expands code examples for both file downloads and uploads. Specifically, it includes minor formatting adjustments to existing TypeScript/JavaScript download examples, adds a new Stagehand v3 example for file download handling, and completely revamps file upload examples for both TypeScript/JavaScript and Python to illustrate a full workflow using Kernel's file system APIs and Playwright's setInputFiles for simulated uploads.

Implementation Checklist

If updating our sample apps, update the info in our Quickstart
If updating our CLI, update the info in our CLI

Testing

mintlify dev works (see installation here)

Docs

Link to a PR in our docs repo documenting your change (if applicable)

Visual Proof

Please provide a screenshot or video demonstrating that your changes work locally:

[Drag and drop your screenshot/video here or use the following format:]
[]

Related Issue

Fixes [Github issue link]

[If this corresponds to a fix from another Kernel OSS repo, include this:]

Fixes [Link to other repo]

[Replace with actual issue link, e.g., Fixes https://github.com/username/repo/issues/123]

Additional Notes

[Any additional context, concerns, or notes for reviewers]

^{Description generated by Mesa. Update settings}

mesa-dot-dev

Performed full review of 16ab9dc...07a6eed

Analysis

Resource leaks - The upload examples contain commented-out cleanup code (browser deletion) that would cause resource leaks if users copy the code as-is without proper cleanup.
Inconsistent standards - There are inconsistencies in markdown formatting (4 vs 3 backticks) and timeout configurations (6s vs 10s) across examples that may cause rendering issues or confusion.
Missing error handling - The examples lack robust error handling mechanisms, particularly for network failures when fetching remote resources, which could lead to unreliable code in production.
Cleanup code patterns - There's an opportunity to establish a consistent pattern for all examples where cleanup code is always included and active, with explanatory comments about its importance.

Tip

Help

Slash Commands:

/review - Request a full code review
/review latest - Review only changes since the last review
/describe - Generate PR description. This will update the PR body or issue comment depending on your configuration
/help - Get help with Mesa commands and configuration options

^{1 files reviewed | 0 comments | Edit Agent Settings • Read Docs}

browsers/file-io.mdx

dprevoznik · 2025-12-04T23:39:47Z

browsers/file-io.mdx

    asyncio.run(main())
+````
+
+```typescript Stagehand v3


Can we move Stagehand v3 out of this section? My thought:
Outer section for Downloads
Sub-section for Playwright
Sub-section for Stagehand v3

See here for inspiration of what I am looking for: https://tbd-6fc993ce-feat-improve-io-docs.mintlify.app/integrations/laminar#browser-agent-framework-examples

For Stagehand v3 section I would def mention the two necessary added params you have to add to your Stagehand config:

downloadsPath: DOWNLOAD_DIR, acceptDownloads: true,

dprevoznik

Made some requested changes!

dprevoznik · 2025-12-04T23:54:14Z

browsers/file-io.mdx

    asyncio.run(main())
+````
+
+```typescript Stagehand v3


See here for inspiration of what I am looking for: https://tbd-6fc993ce-feat-improve-io-docs.mintlify.app/integrations/laminar#browser-agent-framework-examples

dprevoznik · 2025-12-04T23:55:11Z

browsers/file-io.mdx

+  console.log("Download triggered");
+
+  // Wait a bit for the download to complete
+  await new Promise((r) => setTimeout(r, 6000));


I don't believe you need this since we have the waitFor function

dprevoznik · 2025-12-04T23:56:53Z

browsers/file-io.mdx

+  // List files in the download directory to see what was downloaded
+  console.log("Checking download directory...");
+  const files = await kernel.browsers.fs.listFiles(kernelBrowser.session_id, {
+    path: DOWNLOAD_DIR,
+  });
+
+  if (files.length === 0) {
+    console.log("No files found in download directory");
+  } else {


I don't believe we need to try listing the files first. Since we use waitFor, I believe this is redundant

Actually up to line 307

dprevoznik · 2025-12-04T23:57:58Z

browsers/file-io.mdx

+
+        # await browser.close()
+
+    # kernel.browsers.delete_by_id(kernel_browser.session_id)


You can uncomment this browser deletion there.

dprevoznik · 2025-12-05T00:00:56Z

browsers/file-io.mdx

    asyncio.run(main())
+````
+
+```typescript Stagehand v3


For Stagehand v3 section I would def mention the two necessary added params you have to add to your Stagehand config:

downloadsPath: DOWNLOAD_DIR, acceptDownloads: true,

browsers/file-io.mdx

dprevoznik · 2025-12-05T22:11:13Z

browsers/file-io.mdx

+  console.log("Download triggered");
+
+    const downloadedFile = files[0];
+    console.log(`File found: ${downloadedFile.name}`);
+
+    // Wait for the file to be fully available via Kernel's File I/O APIs
+    console.log(`Waiting for file: ${downloadedFile.name}`);


I think there may be some code missing here about the downloadedFile?

Moved beginning playwright note to info section

removed duplicate language from playwright section

Update formatting + remove config addition step in code snippet for stagehand v3

- Moved playwright specific callout to the end of the code snippets in Playwright section - Added formatting changes for typescript code snippets

dprevoznik

LGTM!

ellispinsky added 3 commits December 3, 2025 17:02

initial push

4dca137

remove comment

ad7156e

add code snippets for uploading files

07a6eed

ellispinsky requested a review from dprevoznik December 4, 2025 23:35

mintlify bot deployed to staging December 4, 2025 23:35 View deployment

Merge branch 'main' into feat/improve-io-docs

42d6829

mintlify bot deployed to staging December 4, 2025 23:36 View deployment

mesa-dot-dev bot reviewed Dec 4, 2025

View reviewed changes

dprevoznik reviewed Dec 4, 2025

View reviewed changes

browsers/file-io.mdx Outdated Show resolved Hide resolved

dprevoznik reviewed Dec 4, 2025

View reviewed changes

dprevoznik requested changes Dec 5, 2025

View reviewed changes

improvements pass

7f3115c

mintlify bot deployed to staging December 5, 2025 00:23 View deployment

fix alignment

231bd2d

mintlify bot deployed to staging December 5, 2025 21:12 View deployment

Merge branch 'main' into feat/improve-io-docs

81fa453

mintlify bot deployed to staging December 5, 2025 21:58 View deployment

dprevoznik reviewed Dec 5, 2025

View reviewed changes

browsers/file-io.mdx Outdated Show resolved Hide resolved

dprevoznik reviewed Dec 5, 2025

View reviewed changes

browsers/file-io.mdx Outdated Show resolved Hide resolved

dprevoznik reviewed Dec 5, 2025

View reviewed changes

docs fix

9341e64

mintlify bot deployed to staging December 5, 2025 22:49 View deployment

update helper function

ec58407

mintlify bot deployed to staging December 5, 2025 23:52 View deployment

dprevoznik self-requested a review December 7, 2025 19:26

dprevoznik added 2 commits December 7, 2025 14:26

Merge branch 'main' into feat/improve-io-docs

a488a94

Move info note to Playwright section

f372610

Moved beginning playwright note to info section

mintlify bot deployed to staging December 7, 2025 19:33 View deployment

Remove duplicate language

f1f4c49

removed duplicate language from playwright section

mintlify bot deployed to staging December 7, 2025 19:35 View deployment

dprevoznik added 2 commits December 7, 2025 14:58

Update formatting

8a483e8

Update formatting + remove config addition step in code snippet for stagehand v3

Cleaned up a few items

9bf0162

- Moved playwright specific callout to the end of the code snippets in Playwright section - Added formatting changes for typescript code snippets

mintlify bot deployed to staging December 7, 2025 20:13 View deployment

dprevoznik approved these changes Dec 7, 2025

View reviewed changes

dprevoznik merged commit a0d741b into main Dec 7, 2025
1 check passed

dprevoznik deleted the feat/improve-io-docs branch December 7, 2025 20:16


		# await browser.close()

		# kernel.browsers.delete_by_id(kernel_browser.session_id)

Feat/improve io docs #136

Feat/improve io docs #136

Uh oh!

Conversation

ellispinsky commented Dec 4, 2025

Description

Implementation Checklist

Testing

Docs

Visual Proof

Related Issue

Additional Notes

Uh oh!

mesa-dot-dev bot commented Dec 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Mesa Description

Description

Implementation Checklist

Testing

Docs

Visual Proof

Related Issue

Additional Notes

Uh oh!

mesa-dot-dev bot left a comment

Choose a reason for hiding this comment

Analysis

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dprevoznik left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dprevoznik left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

mesa-dot-dev bot commented Dec 4, 2025 •

edited

Loading