Skip to content

Commit 654c8da

Browse files
committed
fix(flagd): update testbed + step, fix event
Signed-off-by: lea konvalinka <lea.konvalinka@dynatrace.com>
1 parent f0a1db2 commit 654c8da

File tree

4 files changed

+8
-5
lines changed

4 files changed

+8
-5
lines changed

providers/flagd/src/main/java/dev/openfeature/contrib/providers/flagd/resolver/common/ChannelConnector.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,7 @@ private void onStateChange() {
8686
log.debug("Channel state changed to: {}", currentState);
8787
if (currentState == ConnectivityState.TRANSIENT_FAILURE || currentState == ConnectivityState.SHUTDOWN) {
8888
this.onConnectionEvent.accept(new FlagdProviderEvent(
89-
ProviderEvent.PROVIDER_ERROR, Collections.emptyList(), new ImmutableStructure()));
89+
ProviderEvent.PROVIDER_STALE, Collections.emptyList(), new ImmutableStructure()));
9090
}
9191
if (currentState != ConnectivityState.SHUTDOWN) {
9292
log.debug("continuing to monitor the grpc channel");

providers/flagd/src/test/java/dev/openfeature/contrib/providers/flagd/e2e/steps/ProviderSteps.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -200,8 +200,8 @@ public void the_flag_was_modded() {
200200
.statusCode(200);
201201
}
202202

203-
@Then("the client is in {} state")
204-
public void the_client_is_in_fatal_state(String clientState) {
203+
@Then("the client should be in {} state")
204+
public void the_client_should_be_in_fatal_state(String clientState) {
205205
assertThat(state.client.getProviderState()).isEqualTo(ProviderState.valueOf(clientState.toUpperCase()));
206206
}
207207
}

providers/flagd/src/test/java/dev/openfeature/contrib/providers/flagd/e2e/steps/Utils.java

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,10 @@
44
import dev.openfeature.contrib.providers.flagd.resolver.rpc.cache.CacheType;
55
import dev.openfeature.sdk.Value;
66
import java.io.IOException;
7+
import java.util.Arrays;
78
import java.util.List;
89
import java.util.Objects;
10+
import java.util.stream.Collectors;
911
import org.testcontainers.shaded.com.fasterxml.jackson.databind.ObjectMapper;
1012

1113
public final class Utils {
@@ -39,7 +41,8 @@ public static Object convert(String value, String type) throws ClassNotFoundExce
3941
case "CacheType":
4042
return CacheType.valueOf(value.toUpperCase()).getValue();
4143
case "StringList":
42-
return List.of(value);
44+
return value.isEmpty() ? List.of() : Arrays.stream(value.split(",")).map(String::trim).collect(
45+
Collectors.toList());
4346
case "Object":
4447
return Value.objectToValue(new ObjectMapper().readValue(value, Object.class));
4548
}

providers/flagd/test-harness

0 commit comments

Comments
 (0)