Skip to content

Commit 95a880c

Browse files
committed
clean up
Signed-off-by: Konvalinka <lea.konvalinka@dynatrace.com>
1 parent 75392e6 commit 95a880c

File tree

4 files changed

+8
-2
lines changed

4 files changed

+8
-2
lines changed

providers/flagd/src/main/java/dev/openfeature/contrib/providers/flagd/FlagdProvider.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -136,7 +136,7 @@ public void initialize(EvaluationContext evaluationContext) throws Exception {
136136
public void shutdown() {
137137
synchronized (syncResources) {
138138
try {
139-
if (syncResources.isShutDown()) {
139+
if (!syncResources.isInitialized() || syncResources.isShutDown()) {
140140
return;
141141
}
142142

providers/flagd/src/main/java/dev/openfeature/contrib/providers/flagd/resolver/process/storage/connector/sync/SyncStreamQueueSource.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -138,6 +138,7 @@ private void observeSyncStream() {
138138
observer.metadata = getMetadata();
139139
} catch (StatusRuntimeException metaEx) {
140140
if (fatalStatusCodes.contains(metaEx.getStatus().getCode().name())) {
141+
log.debug("Fatal status code for metadata request: {}, not retrying", metaEx.getStatus().getCode());
141142
enqueueFatal(String.format("Fatal: Failed to connect for metadata request, not retrying for error %s", metaEx.getStatus().getCode()));
142143
} else {
143144
// retry for other status codes
@@ -153,6 +154,7 @@ private void observeSyncStream() {
153154
syncFlags(observer);
154155
} catch (StatusRuntimeException ex) {
155156
if (fatalStatusCodes.contains(ex.getStatus().getCode().toString())) {
157+
log.debug("Fatal status code during sync stream: {}, not retrying", ex.getStatus().getCode());
156158
enqueueFatal(String.format("Fatal: Failed to connect for metadata request, not retrying for error %s", ex.getStatus().getCode()));
157159
} else {
158160
// retry for other status codes

providers/flagd/src/main/java/dev/openfeature/contrib/providers/flagd/resolver/rpc/RpcResolver.java

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -424,6 +424,10 @@ private void handleErrorOrComplete() {
424424
onProviderEvent.accept(new FlagdProviderEvent(ProviderEvent.PROVIDER_STALE));
425425
}
426426

427+
/**
428+
* Handles fatal error events (i.e. error codes defined in fatalStatusCodes) by transitioning the provider into
429+
* fatal state
430+
*/
427431
private void handleFatalError() {
428432
log.debug("Emitting provider error event");
429433

providers/flagd/src/test/java/dev/openfeature/contrib/providers/flagd/e2e/steps/ProviderSteps.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ public static void beforeAll() throws IOException {
5353
.withExposedService("flagd", 8015, Wait.forListeningPort())
5454
.withExposedService("flagd", 8080, Wait.forListeningPort())
5555
.withExposedService("envoy", 9211, Wait.forListeningPort())
56-
.withExposedService("envoy", 9212, Wait.forListeningPort())
56+
.withExposedService("envoy", FORBIDDEN_PORT, Wait.forListeningPort())
5757
.withStartupTimeout(Duration.ofSeconds(45));
5858
container.start();
5959
}

0 commit comments

Comments
 (0)