Skip to content

Commit d3f9b9d

Browse files
committed
refactored gRPC history code
1 parent 8ec1824 commit d3f9b9d

File tree

5 files changed

+20
-25
lines changed

5 files changed

+20
-25
lines changed

src/client/components/composer/NewRequest/ComposerNewRequest.jsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -216,6 +216,7 @@ class ComposerNewRequest extends Component {
216216
queryArr: queryArr,
217217
initialQuery: this.props.newRequestStreams.initialQuery,
218218
streamsArr: this.props.newRequestStreams.streamsArr,
219+
streamContent: this.props.newRequestStreams.streamContent,
219220
servicesObj: this.props.newRequestStreams.services,
220221
protoPath: this.props.newRequestStreams.protoPath
221222
};

src/client/components/composer/NewRequest/GRPCAutoInputForm.jsx

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -178,7 +178,6 @@ class GRPCAutoInputForm extends Component {
178178
});
179179
}
180180

181-
182181
render() {
183182
// arrow button used to collapse or open the Stream section
184183
const arrowClass = this.state.show ? 'composer_subtitle_arrow-open' : 'composer_subtitle_arrow-closed';

src/client/components/containers/HistoryContainer.jsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ class HistoryContainer extends Component {
4343
setNewRequestCookies={this.props.setNewRequestCookies}
4444
setNewRequestBody={this.props.setNewRequestBody}
4545
setNewRequestStreams={this.props.setNewRequestStreams}
46-
newRequestStreams={this.props.newRequestStreams}
46+
// newRequestStreams={this.props.newRequestStreams}
4747
/>
4848
})
4949

src/client/components/display/History.jsx

Lines changed: 17 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ class History extends Component {
2828
})
2929
}
3030
let cookieDeeperCopy;
31-
if (this.props.content.request.cookies && !/ws/.test(this.props.content.protocol && !this.content.gRPC)) {
31+
if (this.props.content.request.cookies && !/ws/.test(this.props.content.protocol)) {
3232
cookieDeeperCopy = JSON.parse(JSON.stringify(this.props.content.request.cookies));
3333
cookieDeeperCopy.push({
3434
id: this.props.content.request.cookies.length + 1,
@@ -53,33 +53,27 @@ class History extends Component {
5353
JSONFormatted: this.props.content.request.JSONFormatted ? this.props.content.request.JSONFormatted : true,
5454
protoContent: this.props.content.request.protoContent
5555
}
56-
// set the streamContent arr to equal each query in the streamsArr
57-
const streamsArr = this.props.content.streamsArr;
58-
const streamContent = [];
59-
for (const stream of streamsArr) {
60-
streamContent.push(stream.query);
61-
}
62-
// construct the streams obj from passed in history content & set state in store
63-
const requestStreamsObj = {
64-
streamsArr,
65-
count: this.props.content.queryArr.length,
66-
streamContent,
67-
selectedPackage: this.props.content.packageName,
68-
selectedRequest: this.props.content.rpc,
69-
selectedService: this.props.content.service,
70-
selectedStreamingType: this.props.content.request.method,
71-
initialQuery: this.props.content.initialQuery,
72-
queryArr: this.props.content.queryArr,
73-
protoPath: this.props.content.protoPath,
74-
services: this.props.content.servicesObj
75-
}
7656
this.props.setNewRequestFields(requestFieldObj);
7757
this.props.setNewRequestHeaders(requestHeadersObj);
7858
this.props.setNewRequestCookies(requestCookiesObj);
7959
this.props.setNewRequestBody(requestBodyObj);
80-
this.props.setNewRequestStreams(requestStreamsObj)
8160
// for gRPC
8261
if (this.props.content && this.props.content.gRPC) {
62+
// construct the streams obj from passed in history content & set state in store
63+
const requestStreamsObj = {
64+
streamsArr: this.props.content.streamsArr,
65+
count: this.props.content.queryArr.length,
66+
streamContent: this.props.content.streamContent,
67+
selectedPackage: this.props.content.packageName,
68+
selectedRequest: this.props.content.rpc,
69+
selectedService: this.props.content.service,
70+
selectedStreamingType: this.props.content.request.method,
71+
initialQuery: this.props.content.initialQuery,
72+
queryArr: this.props.content.queryArr,
73+
protoPath: this.props.content.protoPath,
74+
services: this.props.content.servicesObj
75+
}
76+
this.props.setNewRequestStreams(requestStreamsObj)
8377
// need to place logic in callback otherwise code won't work and returns null
8478
this.setState({
8579
...this.state
@@ -102,6 +96,7 @@ class History extends Component {
10296
})
10397
}
10498
}
99+
105100
deleteHistory(e) {
106101
this.props.deleteFromHistory(this.props.content);
107102
historyController.deleteHistoryFromIndexedDb(e.target.id);

src/client/components/display/HistoryDate.jsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ class HistoryDate extends Component {
3737
setNewRequestCookies={this.props.setNewRequestCookies}
3838
setNewRequestBody={this.props.setNewRequestBody}
3939
setNewRequestStreams={this.props.setNewRequestStreams}
40-
newRequestStreams={this.props.newRequestStreams}
40+
// newRequestStreams={this.props.newRequestStreams}
4141
/>
4242
})
4343

0 commit comments

Comments
 (0)