From b6a8a48a2c4c4db75f1e79332753d4e0b1953595 Mon Sep 17 00:00:00 2001 From: Eunbin Son Date: Mon, 22 Jun 2026 11:29:03 +0900 Subject: [PATCH] Fix SpanLimitsBuilder Javadoc to match non-negative argument check --- .../sdk/trace/SpanLimitsBuilder.java | 23 +++++++++++-------- 1 file changed, 13 insertions(+), 10 deletions(-) diff --git a/sdk/trace/src/main/java/io/opentelemetry/sdk/trace/SpanLimitsBuilder.java b/sdk/trace/src/main/java/io/opentelemetry/sdk/trace/SpanLimitsBuilder.java index 353bc19b044..30f8f69a562 100644 --- a/sdk/trace/src/main/java/io/opentelemetry/sdk/trace/SpanLimitsBuilder.java +++ b/sdk/trace/src/main/java/io/opentelemetry/sdk/trace/SpanLimitsBuilder.java @@ -29,9 +29,10 @@ public final class SpanLimitsBuilder { /** * Sets the max number of attributes per {@link Span}. * - * @param maxNumberOfAttributes the max number of attributes per {@link Span}. Must be positive. + * @param maxNumberOfAttributes the max number of attributes per {@link Span}. Must not be + * negative. * @return this. - * @throws IllegalArgumentException if {@code maxNumberOfAttributes} is not positive. + * @throws IllegalArgumentException if {@code maxNumberOfAttributes} is negative. */ public SpanLimitsBuilder setMaxNumberOfAttributes(int maxNumberOfAttributes) { Utils.checkArgument(maxNumberOfAttributes >= 0, "maxNumberOfAttributes must be non-negative"); @@ -42,9 +43,9 @@ public SpanLimitsBuilder setMaxNumberOfAttributes(int maxNumberOfAttributes) { /** * Sets the max number of events per {@link Span}. * - * @param maxNumberOfEvents the max number of events per {@link Span}. Must be positive. + * @param maxNumberOfEvents the max number of events per {@link Span}. Must not be negative. * @return this. - * @throws IllegalArgumentException if {@code maxNumberOfEvents} is not positive. + * @throws IllegalArgumentException if {@code maxNumberOfEvents} is negative. */ public SpanLimitsBuilder setMaxNumberOfEvents(int maxNumberOfEvents) { Utils.checkArgument(maxNumberOfEvents >= 0, "maxNumberOfEvents must be non-negative"); @@ -55,9 +56,9 @@ public SpanLimitsBuilder setMaxNumberOfEvents(int maxNumberOfEvents) { /** * Sets the max number of links per {@link Span}. * - * @param maxNumberOfLinks the max number of links per {@link Span}. Must be positive. + * @param maxNumberOfLinks the max number of links per {@link Span}. Must not be negative. * @return this. - * @throws IllegalArgumentException if {@code maxNumberOfLinks} is not positive. + * @throws IllegalArgumentException if {@code maxNumberOfLinks} is negative. */ public SpanLimitsBuilder setMaxNumberOfLinks(int maxNumberOfLinks) { Utils.checkArgument(maxNumberOfLinks >= 0, "maxNumberOfLinks must be non-negative"); @@ -68,9 +69,10 @@ public SpanLimitsBuilder setMaxNumberOfLinks(int maxNumberOfLinks) { /** * Sets the max number of attributes per event. * - * @param maxNumberOfAttributesPerEvent the max number of attributes per event. Must be positive. + * @param maxNumberOfAttributesPerEvent the max number of attributes per event. Must not be + * negative. * @return this. - * @throws IllegalArgumentException if {@code maxNumberOfAttributesPerEvent} is not positive. + * @throws IllegalArgumentException if {@code maxNumberOfAttributesPerEvent} is negative. */ public SpanLimitsBuilder setMaxNumberOfAttributesPerEvent(int maxNumberOfAttributesPerEvent) { Utils.checkArgument( @@ -82,9 +84,10 @@ public SpanLimitsBuilder setMaxNumberOfAttributesPerEvent(int maxNumberOfAttribu /** * Sets the max number of attributes per link. * - * @param maxNumberOfAttributesPerLink the max number of attributes per link. Must be positive. + * @param maxNumberOfAttributesPerLink the max number of attributes per link. Must not be + * negative. * @return this. - * @throws IllegalArgumentException if {@code maxNumberOfAttributesPerLink} is not positive. + * @throws IllegalArgumentException if {@code maxNumberOfAttributesPerLink} is negative. */ public SpanLimitsBuilder setMaxNumberOfAttributesPerLink(int maxNumberOfAttributesPerLink) { Utils.checkArgument(