From 03e68f7463cd032b1518cc800c28402b705b6bf1 Mon Sep 17 00:00:00 2001 From: LKuemmel Date: Fri, 2 May 2025 15:18:16 +0200 Subject: [PATCH 1/2] refactor algodue --- packages/modules/devices/algodue/algodue/device.py | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/packages/modules/devices/algodue/algodue/device.py b/packages/modules/devices/algodue/algodue/device.py index ce0fb35def..8b3ff704b6 100644 --- a/packages/modules/devices/algodue/algodue/device.py +++ b/packages/modules/devices/algodue/algodue/device.py @@ -26,12 +26,13 @@ def update_components(components: Iterable[counter.AlgodueCounter]): with SingleComponentUpdateContext(component.fault_state): component.update() - try: + def initializer(): + nonlocal client client = modbus.ModbusTcpClient_(device_config.configuration.ip_address, device_config.configuration.port) - except Exception: - log.exception("Fehler in create_device") + return ConfigurableDevice( device_config=device_config, + initializer=initializer, component_factory=ComponentFactoryByType( counter=create_counter_component ), From b8bbf258affdd6b9aedbb64c67b6306c16974b38 Mon Sep 17 00:00:00 2001 From: LKuemmel Date: Fri, 2 May 2025 15:22:16 +0200 Subject: [PATCH 2/2] remove comment --- packages/modules/devices/algodue/algodue/counter.py | 1 - 1 file changed, 1 deletion(-) diff --git a/packages/modules/devices/algodue/algodue/counter.py b/packages/modules/devices/algodue/algodue/counter.py index 20717c8f89..3f432a816a 100644 --- a/packages/modules/devices/algodue/algodue/counter.py +++ b/packages/modules/devices/algodue/algodue/counter.py @@ -24,7 +24,6 @@ def __init__(self, component_config: AlgodueCounterSetup, **kwargs: Any) -> None self.kwargs: KwargsDict = kwargs def initialize(self) -> None: - # return self.__device_id: int = self.kwargs['device_id'] self.__tcp_client: modbus.ModbusTcpClient_ = self.kwargs['tcp_client'] self.__modbus_id: int = self.kwargs['modbus_id']