From 3ab0318a709274bf5624a8158a64e0a33829e1ed Mon Sep 17 00:00:00 2001 From: LKuemmel Date: Wed, 29 Oct 2025 14:04:22 +0100 Subject: [PATCH 1/3] fix solaredge --- packages/modules/devices/solaredge/solaredge/counter.py | 1 + packages/modules/devices/solaredge/solaredge/inverter.py | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/packages/modules/devices/solaredge/solaredge/counter.py b/packages/modules/devices/solaredge/solaredge/counter.py index 21f9073bd0..d141e99b6b 100644 --- a/packages/modules/devices/solaredge/solaredge/counter.py +++ b/packages/modules/devices/solaredge/solaredge/counter.py @@ -54,6 +54,7 @@ def update(self): ) resp = self.__tcp_client.read_holding_registers_bulk( self.registers.currents, 52, mapping=reg_mapping, unit=self.component_config.configuration.modbus_id) + log.debug(f"resp counter: {resp}") counter_state = CounterState( imported=scale_registers(resp[self.registers.imported], resp[self.registers.imp_exp_scale]), diff --git a/packages/modules/devices/solaredge/solaredge/inverter.py b/packages/modules/devices/solaredge/solaredge/inverter.py index 9e40716dfa..9009a26a10 100644 --- a/packages/modules/devices/solaredge/solaredge/inverter.py +++ b/packages/modules/devices/solaredge/solaredge/inverter.py @@ -59,7 +59,7 @@ def update(self) -> None: def read_state(self): resp = self.__tcp_client.read_holding_registers_bulk( - Register.POWER, 18, mapping=self.REG_MAPPING, unit=self.component_config.configuration.modbus_id) + Register.CURRENTS, 30, mapping=self.REG_MAPPING, unit=self.component_config.configuration.modbus_id) power = scale_registers(resp[Register.POWER], resp[Register.POWER_SCALE]) * -1 imported, _ = self.sim_counter.sim_count(power) From 5481d4c6b963a1d95362591c75846054fbacfb05 Mon Sep 17 00:00:00 2001 From: LKuemmel Date: Wed, 29 Oct 2025 14:07:12 +0100 Subject: [PATCH 2/3] fix --- packages/modules/devices/solaredge/solaredge/counter.py | 1 + 1 file changed, 1 insertion(+) diff --git a/packages/modules/devices/solaredge/solaredge/counter.py b/packages/modules/devices/solaredge/solaredge/counter.py index d141e99b6b..fc54abb68e 100644 --- a/packages/modules/devices/solaredge/solaredge/counter.py +++ b/packages/modules/devices/solaredge/solaredge/counter.py @@ -48,6 +48,7 @@ def update(self): (self.registers.power_factors, [ModbusDataType.INT_16]*3), (self.registers.power_factors_scale, ModbusDataType.INT_16), (self.registers.frequency, ModbusDataType.INT_16), + (self.registers.frequency_scale, ModbusDataType.INT_16), (self.registers.imported, ModbusDataType.UINT_32), (self.registers.exported, ModbusDataType.UINT_32), (self.registers.imp_exp_scale, ModbusDataType.INT_16), From fb9833de3e5d7d1058bf671950af10a7a934658e Mon Sep 17 00:00:00 2001 From: LKuemmel Date: Wed, 29 Oct 2025 14:13:10 +0100 Subject: [PATCH 3/3] clean up --- packages/modules/devices/solaredge/solaredge/counter.py | 1 - 1 file changed, 1 deletion(-) diff --git a/packages/modules/devices/solaredge/solaredge/counter.py b/packages/modules/devices/solaredge/solaredge/counter.py index fc54abb68e..be654e2ef4 100644 --- a/packages/modules/devices/solaredge/solaredge/counter.py +++ b/packages/modules/devices/solaredge/solaredge/counter.py @@ -55,7 +55,6 @@ def update(self): ) resp = self.__tcp_client.read_holding_registers_bulk( self.registers.currents, 52, mapping=reg_mapping, unit=self.component_config.configuration.modbus_id) - log.debug(f"resp counter: {resp}") counter_state = CounterState( imported=scale_registers(resp[self.registers.imported], resp[self.registers.imp_exp_scale]),