Skip to content

Commit 2f1ae31

Browse files
committed
🐛 (manager) Make sure to emit Folders
1 parent 7e7738e commit 2f1ae31

File tree

2 files changed

+4
-6
lines changed

2 files changed

+4
-6
lines changed

ingestors/manager.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -202,8 +202,9 @@ def ingest_entity(self, entity):
202202
continue
203203
self.ingest(file_path, entity)
204204
return
205-
# don't emit this entity if we didn't find a file to ingest
206-
self.finalize(entity, emit=False)
205+
# don't emit this entity if we didn't find a file to ingest and its not
206+
# a folder
207+
self.finalize(entity, emit=entity.schema.is_a("Folder"))
207208

208209
def ingest(self, file_path, entity, **kwargs):
209210
"""Main execution step of an ingestor."""

ingestors/tasks.py

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
import gc
2-
import logging
32
from pathlib import Path
43

54
from anystore.logging import get_logger
@@ -21,8 +20,6 @@
2120
app = make_app(__loader__.name)
2221
sync_app = make_app(__loader__.name, sync=True)
2322

24-
log = logging.getLogger(__name__)
25-
2623

2724
@task(app=app)
2825
def ingest(job: DatasetJob) -> None:
@@ -41,7 +38,7 @@ def ingest(job: DatasetJob) -> None:
4138

4239
emitted = manager.get_emitted()
4340
if not len(emitted):
44-
raise RuntimeError("No entities to be emitted!")
41+
job.log.error("No entities to be emitted!")
4542

4643
for entity in emitted:
4744
if entity.schema.is_a("Analyzable"):

0 commit comments

Comments
 (0)