Fix Detekt issues

Author: zerox80

opencloudApp/src/main/java/eu/opencloud/android/presentation/files/details/FileDetailsFragment.kt

@@ -24,7 +24,7 @@ package eu.opencloud.android.presentation.files.details
 
 import android.accounts.Account
 import android.content.Intent
-import android.graphics.Bitmap
+
 import android.net.Uri
 import android.os.Build
 import android.os.Bundle
@@ -38,7 +38,7 @@ import androidx.browser.customtabs.CustomTabsIntent
 import androidx.core.view.isVisible
 import androidx.work.WorkInfo
 import com.google.android.material.snackbar.Snackbar
-import eu.opencloud.android.MainApp
+
 import eu.opencloud.android.R
 import coil.load
 import eu.opencloud.android.databinding.FileDetailsFragmentBinding
@@ -430,7 +430,13 @@ class FileDetailsFragment : FileFragment() {
                 }
             }
             if (ocFile.isImage) {
-                imageView.load(ThumbnailsRequester.getPreviewUriForFile(OCFileWithSyncInfo(ocFile, null), fileDetailsViewModel.getAccount()), ThumbnailsRequester.getCoilImageLoader(fileDetailsViewModel.getAccount())) {
+                imageView.load(
+                    ThumbnailsRequester.getPreviewUriForFile(
+                        OCFileWithSyncInfo(ocFile, null),
+                        fileDetailsViewModel.getAccount()
+                    ),
+                    ThumbnailsRequester.getCoilImageLoader(fileDetailsViewModel.getAccount())
+                ) {
                     placeholder(MimetypeIconUtil.getFileTypeIconId(ocFile.mimeType, ocFile.fileName))
                     error(MimetypeIconUtil.getFileTypeIconId(ocFile.mimeType, ocFile.fileName))
                     crossfade(true)

opencloudApp/src/main/java/eu/opencloud/android/presentation/files/filelist/FileListAdapter.kt

@@ -25,7 +25,7 @@ package eu.opencloud.android.presentation.files.filelist
 
 import android.accounts.Account
 import android.content.Context
-import android.graphics.Bitmap
+
 import android.graphics.Color
 import android.view.LayoutInflater
 import android.view.View

opencloudApp/src/main/java/eu/opencloud/android/presentation/files/filelist/MainFileListFragment.kt

@@ -606,7 +606,7 @@ class MainFileListFragment : Fragment(),
                     dialog.dismiss()
                 }
 
-                val thumbnailBottomSheet = fileOptionsBottomSheetSingleFile.findViewById<ImageView>(R.id.thumbnail_bottom_sheet)
+
 
                 val fileSizeBottomSheet = fileOptionsBottomSheetSingleFile.findViewById<TextView>(R.id.file_size_bottom_sheet)
                 fileSizeBottomSheet.text = DisplayUtils.bytesToHumanReadable(file.length, requireContext(), true)

opencloudApp/src/main/java/eu/opencloud/android/presentation/sharing/ShareFileFragment.kt

@@ -240,13 +240,15 @@ class ShareFileFragment : Fragment(), ShareUserListAdapter.ShareUserAdapterListe
             )
         )
         if (file!!.isImage) {
-            binding.shareFileIcon.load(ThumbnailsRequester.getPreviewUriForFile(file!!, account!!), ThumbnailsRequester.getCoilImageLoader(account!!)) {
+            binding.shareFileIcon.load(
+                ThumbnailsRequester.getPreviewUriForFile(file!!, account!!),
+                ThumbnailsRequester.getCoilImageLoader(account!!)
+            ) {
                 placeholder(MimetypeIconUtil.getFileTypeIconId(file!!.mimeType, file!!.fileName))
                 error(MimetypeIconUtil.getFileTypeIconId(file!!.mimeType, file!!.fileName))
                 crossfade(true)
             }
         }
-        // Name
         binding.shareFileName.text = file?.fileName
 
         // Size

opencloudApp/src/main/java/eu/opencloud/android/presentation/thumbnails/ThumbnailsRequester.kt

@@ -28,7 +28,6 @@ import coil.disk.DiskCache
 import coil.memory.MemoryCache
 import coil.util.DebugLogger
 import eu.opencloud.android.MainApp.Companion.appContext
-import eu.opencloud.android.R
 import eu.opencloud.android.data.ClientManager
 import java.util.concurrent.ConcurrentHashMap
 import eu.opencloud.android.domain.files.model.OCFile
@@ -49,7 +48,6 @@ import org.koin.core.component.KoinComponent
 import org.koin.core.component.inject
 import timber.log.Timber
 import java.util.Locale
-import kotlin.math.roundToInt
 
 object ThumbnailsRequester : KoinComponent {
     private val clientManager: ClientManager by inject()
@@ -89,25 +87,21 @@ object ThumbnailsRequester : KoinComponent {
         return "$baseUrl/index.php/avatar/${android.net.Uri.encode(username)}/384"
     }
 
-    fun getPreviewUriForFile(file: OCFile, account: Account, etag: String? = null): String {
-        return getPreviewUri(file.remotePath, etag ?: file.etag, account)
-    }
+    fun getPreviewUriForFile(file: OCFile, account: Account, etag: String? = null): String =
+        getPreviewUri(file.remotePath, etag ?: file.etag, account)
 
-    fun getPreviewUriForFile(fileWithSyncInfo: OCFileWithSyncInfo, account: Account): String {
-        return getPreviewUriForFile(fileWithSyncInfo.file, account)
-    }
+    fun getPreviewUriForFile(fileWithSyncInfo: OCFileWithSyncInfo, account: Account): String =
+        getPreviewUriForFile(fileWithSyncInfo.file, account)
 
-    fun getPreviewUriForSpaceSpecial(spaceSpecial: SpaceSpecial): String {
-        return String.format(Locale.US, SPACE_SPECIAL_PREVIEW_URI, spaceSpecial.webDavUrl, 1024, 1024, spaceSpecial.eTag)
-    }
+    fun getPreviewUriForSpaceSpecial(spaceSpecial: SpaceSpecial): String =
+        String.format(Locale.US, SPACE_SPECIAL_PREVIEW_URI, spaceSpecial.webDavUrl, 1024, 1024, spaceSpecial.eTag)
 
     private fun getPreviewUri(remotePath: String?, etag: String?, account: Account): String {
         val accountManager = AccountManager.get(appContext)
         val baseUrl = accountManager.getUserData(account, eu.opencloud.android.lib.common.accounts.AccountUtils.Constants.KEY_OC_BASE_URL)
-        
         val path = if (remotePath?.startsWith("/") == true) remotePath else "/$remotePath"
         val encodedPath = Uri.encode(path, "/")
-        
+
         return String.format(Locale.US, FILE_PREVIEW_URI, baseUrl, encodedPath, 1024, 1024, etag)
     }