Skip to content

Commit b763d30

Browse files
authored
Hangs when instantiating a simulation.
2 parents 598e32f + 8b82716 commit b763d30

File tree

92 files changed

+1801
-1433
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

92 files changed

+1801
-1433
lines changed

.github/workflows/ci.yml

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -184,7 +184,7 @@ jobs:
184184
install_uninstall_and_package: ON
185185
use_install_prefix: ON
186186
- name: 'JavaScript bindings'
187-
os: macos-15
187+
os: ubuntu-22.04
188188
build_type: Release
189189
code_analysis: OFF
190190
code_coverage: OFF
@@ -251,7 +251,7 @@ jobs:
251251
context: PATH=$GITHUB_WORKSPACE:$PATH
252252
target: check_code_formatting
253253
- name: 'JavaScript code formatting'
254-
os: macos-15
254+
os: ubuntu-22.04
255255
build_type: Release
256256
code_analysis: OFF
257257
code_coverage: OFF
@@ -376,10 +376,13 @@ jobs:
376376
sudo mv clang-tidy /usr/local/bin
377377
- name: Install Emscripten
378378
if: ${{ matrix.javascript_support == 'ON' }}
379-
run: brew install --overwrite emscripten
379+
uses: mymindstorm/setup-emsdk@v14
380380
- name: Install Biome
381381
if: ${{ matrix.target == 'javascript_check_code_formatting' }}
382-
run: brew install --overwrite biome
382+
run: |
383+
curl -L https://github.com/biomejs/biome/releases/latest/download/biome-linux-x64 -o biome
384+
chmod +x biome
385+
mv biome /usr/local/bin
383386
- name: Install uv
384387
if: ${{ matrix.documentation == 'ON' || matrix.python_support == 'ON' || matrix.target == 'python_check_code_formatting' }}
385388
uses: astral-sh/setup-uv@v6

VERSION.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
0.20251027.0
1+
0.20251030.0

cmake/base64encoder.cpp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -30,8 +30,8 @@ int main(int pArgC, char *pArgV[])
3030
return 1;
3131
}
3232

33-
std::uintmax_t fileSize = std::filesystem::file_size(pArgV[1]);
34-
char *buffer = new char[fileSize];
33+
std::uintmax_t fileSize {std::filesystem::file_size(pArgV[1])};
34+
char *buffer {new char[fileSize]};
3535
std::ifstream file(pArgV[1], std::ios::binary);
3636

3737
file.read(buffer, fileSize);
@@ -44,7 +44,7 @@ int main(int pArgC, char *pArgV[])
4444

4545
file.close();
4646

47-
char *base64 = new char[modp_b64_encode_len(fileSize)];
47+
char *base64 {new char[modp_b64_encode_len(fileSize)]};
4848

4949
modp_b64_encode(base64, buffer, fileSize);
5050

extern/nanobind/src/implicit.cpp

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -15,13 +15,13 @@ NAMESPACE_BEGIN(detail)
1515

1616
void implicitly_convertible(const std::type_info *src,
1717
const std::type_info *dst) noexcept {
18-
nb_internals *internals_ = internals;
19-
type_data *t = nb_type_c2p(internals_, dst);
18+
nb_internals *internals_ {internals};
19+
type_data *t {nb_type_c2p(internals_, dst)};
2020
check(t, "nanobind::detail::implicitly_convertible(src=%s, dst=%s): "
2121
"destination type unknown!", type_name(src), type_name(dst));
2222

2323
lock_internals guard(internals_);
24-
size_t size = 0;
24+
size_t size {0};
2525

2626
if (t->flags & (uint32_t) type_flags::has_implicit_conversions) {
2727
while (t->implicit.cpp && t->implicit.cpp[size])
@@ -45,13 +45,13 @@ void implicitly_convertible(const std::type_info *src,
4545
void implicitly_convertible(bool (*predicate)(PyTypeObject *, PyObject *,
4646
cleanup_list *),
4747
const std::type_info *dst) noexcept {
48-
nb_internals *internals_ = internals;
49-
type_data *t = nb_type_c2p(internals_, dst);
48+
nb_internals *internals_ {internals};
49+
type_data *t {nb_type_c2p(internals_, dst)};
5050
check(t, "nanobind::detail::implicitly_convertible(src=<predicate>, dst=%s): "
5151
"destination type unknown!", type_name(dst));
5252

5353
lock_internals guard(internals_);
54-
size_t size = 0;
54+
size_t size {0};
5555

5656
if (t->flags & (uint32_t) type_flags::has_implicit_conversions) {
5757
while (t->implicit.py && t->implicit.py[size])

src/api/libopencor/file.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -79,8 +79,8 @@ class LIBOPENCOR_EXPORT File: public Logger
7979
* Factory method to create a @ref File object:
8080
*
8181
* ```
82-
* auto localFile = libOpenCOR::File::create("/some/path/file.txt");
83-
* auto remoteFile = libOpenCOR::File::create("https://some.domain.com/file.txt");
82+
* auto localFile {libOpenCOR::File::create("/some/path/file.txt")};
83+
* auto remoteFile {libOpenCOR::File::create("https://some.domain.com/file.txt")};
8484
* ```
8585
*
8686
* Note: if there is already a @ref File object for the given file name or URL then we return it after having reset

src/api/libopencor/sedanalysis.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -50,8 +50,8 @@ class LIBOPENCOR_EXPORT SedAnalysis: public SedSimulation
5050
* Factory method to create a @ref SedAnalysis object:
5151
*
5252
* ```
53-
* auto document = libOpenCOR::SedDocument::create();
54-
* auto simulation = libOpenCOR::SedAnalysis::create(document);
53+
* auto document {libOpenCOR::SedDocument::create()};
54+
* auto simulation {libOpenCOR::SedAnalysis::create(document)};
5555
* ```
5656
*
5757
* @param pDocument The @ref SedDocument object to which the @ref SedAnalysis object is to belong.

src/api/libopencor/sedchangeattribute.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ class LIBOPENCOR_EXPORT SedChangeAttribute: public SedChange
5050
* Factory method to create a @ref SedChangeAttribute object:
5151
*
5252
* ```
53-
* auto simulation = libOpenCOR::SedChangeAttribute::create(component, variable, newValue);
53+
* auto simulation {libOpenCOR::SedChangeAttribute::create(component, variable, newValue)};
5454
* ```
5555
*
5656
* @param pComponentName The name of the component, as a @c std::string, where the target is located.

src/api/libopencor/seddocument.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ class LIBOPENCOR_EXPORT SedDocument: public Logger
5353
* Factory method to create a @ref SedDocument object:
5454
*
5555
* ```
56-
* auto document = libOpenCOR::SedDocument::create();
56+
* auto document {libOpenCOR::SedDocument::create()};
5757
* ```
5858
*
5959
* @param pFile The @ref File, if any, used to initialise this @ref SedDocument object.

src/api/libopencor/sedmodel.h

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -53,9 +53,9 @@ class LIBOPENCOR_EXPORT SedModel: public SedBase
5353
* Factory method to create a @ref SedModel object:
5454
*
5555
* ```
56-
* auto document = libOpenCOR::SedDocument::create();
57-
* auto file = libOpenCOR::File::create("/some/path/file.txt");
58-
* auto model = libOpenCOR::SedModel::create(document, file);
56+
* auto document {libOpenCOR::SedDocument::create()};
57+
* auto file {libOpenCOR::File::create("/some/path/file.txt")};
58+
* auto model {libOpenCOR::SedModel::create(document, file)};
5959
* ```
6060
*
6161
* @param pDocument The @ref SedDocument object to which the @ref SedModel object is to belong.

src/api/libopencor/sedonestep.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -49,8 +49,8 @@ class LIBOPENCOR_EXPORT SedOneStep: public SedSimulation
4949
* Factory method to create a @ref SedOneStep object:
5050
*
5151
* ```
52-
* auto document = libOpenCOR::SedDocument::create();
53-
* auto simulation = libOpenCOR::SedOneStep::create(document);
52+
* auto document {libOpenCOR::SedDocument::create()};
53+
* auto simulation {libOpenCOR::SedOneStep::create(document)};
5454
* ```
5555
*
5656
* @param pDocument The @ref SedDocument object to which the @ref SedOneStep object is to belong.

0 commit comments

Comments
 (0)