Skip to content

Commit 1fb3246

Browse files
committed
CD: reenable code signing on Windows.
1 parent 2ecd35f commit 1fb3246

File tree

1 file changed

+17
-20
lines changed

1 file changed

+17
-20
lines changed

.github/workflows/cd.yml

Lines changed: 17 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -34,10 +34,9 @@ jobs:
3434
APPLE_ID: ${{ secrets.APPLE_ID }}
3535
APPLE_APP_SPECIFIC_PASSWORD: ${{ secrets.APPLE_APP_SPECIFIC_PASSWORD }}
3636
APPLE_TEAM_ID: ${{ secrets.APPLE_TEAM_ID }}
37-
#---GRY--- Temporarily disable code signing since our EV certificate has expired and we are waiting for a new one.
38-
# WINDOWS_CSC_LINK: EVCertificate.pfx
39-
# WINDOWS_CSC_KEY_PASSWORD: ${{ secrets.EV_CERTIFICATE_PASSWORD }}
40-
# EV_CERTIFICATE_BASE64: ${{ secrets.EV_CERTIFICATE_BASE64 }}
37+
WINDOWS_CSC_LINK: EVCertificate.pfx
38+
WINDOWS_CSC_KEY_PASSWORD: ${{ secrets.EV_CERTIFICATE_PASSWORD }}
39+
EV_CERTIFICATE_BASE64: ${{ secrets.EV_CERTIFICATE_BASE64 }}
4140
MACOS_CSC_LINK: DeveloperIDApplicationCertificate.p12
4241
MACOS_CSC_KEY_PASSWORD: ${{ secrets.DEVELOPER_ID_APPLICATION_CERTIFICATE_PASSWORD }}
4342
DEVELOPER_ID_APPLICATION_CERTIFICATE_BASE64: ${{ secrets.DEVELOPER_ID_APPLICATION_CERTIFICATE_BASE64 }}
@@ -50,14 +49,13 @@ jobs:
5049
timezoneMacos: 'Pacific/Auckland'
5150
- name: Check out OpenCOR
5251
uses: actions/checkout@v4
53-
#---GRY--- Temporarily disable code signing since our EV certificate has expired and we are waiting for a new one.
54-
# - name: Retrieve the EV certificate (Windows only)
55-
# if: ${{ runner.os == 'Windows' }}
56-
# shell: bash
57-
# run: |
58-
# echo "CSC_LINK=$(echo $WINDOWS_CSC_LINK)" >> $GITHUB_ENV
59-
# echo "CSC_KEY_PASSWORD=$(echo $WINDOWS_CSC_KEY_PASSWORD)" >> $GITHUB_ENV
60-
# echo -n $EV_CERTIFICATE_BASE64 | base64 -d > $WINDOWS_CSC_LINK
52+
- name: Retrieve the EV certificate (Windows only)
53+
if: ${{ runner.os == 'Windows' }}
54+
shell: bash
55+
run: |
56+
echo "CSC_LINK=$(echo $WINDOWS_CSC_LINK)" >> $GITHUB_ENV
57+
echo "CSC_KEY_PASSWORD=$(echo $WINDOWS_CSC_KEY_PASSWORD)" >> $GITHUB_ENV
58+
echo -n $EV_CERTIFICATE_BASE64 | base64 -d > $WINDOWS_CSC_LINK
6159
- name: Retrieve the Developer ID Application certificates (macOS only)
6260
if: ${{ runner.os == 'macOS' }}
6361
run: |
@@ -78,14 +76,13 @@ jobs:
7876
unzip -j bun.zip -d $env:USERPROFILE\.bun
7977
del bun.zip
8078
echo "$env:USERPROFILE\.bun" >> $env:GITHUB_PATH
81-
#---GRY--- Temporarily disable code signing since our EV certificate has expired and we are waiting for a new one.
82-
# - name: Make sure that we can sign OpenCOR (Windows ARM only)
83-
# if: ${{ matrix.name == 'Windows (ARM)' }}
84-
# run: |
85-
# curl -L https://npmmirror.com/mirrors/electron-builder-binaries/winCodeSign-2.6.0/winCodeSign-2.6.0.7z -o winCodeSign.7z
86-
# 7z x winCodeSign.7z -oC:\Users\runneradmin\AppData\Local\electron-builder\Cache\winCodeSign\winCodeSign-2.6.0
87-
# cd C:\Users\runneradmin\AppData\Local\electron-builder\Cache\winCodeSign\winCodeSign-2.6.0\windows-10
88-
# mv x64 arm64
79+
- name: Make sure that we can sign OpenCOR (Windows ARM only)
80+
if: ${{ matrix.name == 'Windows (ARM)' }}
81+
run: |
82+
curl -L https://npmmirror.com/mirrors/electron-builder-binaries/winCodeSign-2.6.0/winCodeSign-2.6.0.7z -o winCodeSign.7z
83+
7z x winCodeSign.7z -oC:\Users\runneradmin\AppData\Local\electron-builder\Cache\winCodeSign\winCodeSign-2.6.0
84+
cd C:\Users\runneradmin\AppData\Local\electron-builder\Cache\winCodeSign\winCodeSign-2.6.0\windows-10
85+
mv x64 arm64
8986
- name: Install libopenjp2-tools (Linux ARM only)
9087
if: ${{ matrix.name == 'Linux (ARM)' }}
9188
run: |

0 commit comments

Comments
 (0)