Skip to content

Conversation

@Lunyachek
Copy link
Contributor

@Lunyachek Lunyachek commented Mar 21, 2025

Description

This PR is our proposal to update the Twitter icon to the new X logo in the user Profile and Account.

This PR is related to corresponding PRs in the edx-platform and frontend-app-account repositories.

Снимок экрана 2025-04-15 в 14 04 57 Снимок экрана 2025-04-15 в 14 05 47

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Mar 21, 2025
@openedx-webhooks
Copy link

openedx-webhooks commented Mar 21, 2025

Thanks for the pull request, @Lunyachek!

This repository is currently maintained by @openedx/2u-infinity.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.


Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@github-project-automation github-project-automation bot moved this to Needs Triage in Contributions Mar 21, 2025
@mphilbrick211 mphilbrick211 moved this from Needs Triage to Waiting on Author in Contributions Mar 24, 2025
@Lunyachek Lunyachek force-pushed the lunyachel/feat/change-twitter-to-x-master branch from 3880d81 to 5d57013 Compare April 15, 2025 13:23
@Lunyachek Lunyachek marked this pull request as ready for review April 30, 2025 16:06
@Lunyachek Lunyachek requested a review from a team as a code owner April 30, 2025 16:06
@mphilbrick211
Copy link

Hi @openedx/2u-infinity - could someone please take a look at this? Thanks!

@mphilbrick211 mphilbrick211 moved this from Waiting on Author to Ready for Review in Contributions May 27, 2025
Copy link
Contributor

@sundasnoreen12 sundasnoreen12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi @Lunyachek, test cases are failing. Could you please take a look?

@awais-ansari
Copy link
Contributor

@Lunyachek, test cases are failing

@sarina
Copy link
Contributor

sarina commented Oct 14, 2025

@Lunyachek could you please rebase and address failing tests? We need to merge all 3 of the Twitter PRs before the release, or after, we can't do half and half.

@mphilbrick211 mphilbrick211 moved this from Ready for Review to In Eng Review in Contributions Nov 4, 2025
@mphilbrick211 mphilbrick211 added the waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. label Nov 4, 2025
@sarina
Copy link
Contributor

sarina commented Dec 2, 2025

@Lunyachek please rebase this PR ASAP so we can get it merged now that the blocking PR has been merged.

@sarina sarina moved this from In Eng Review to Waiting on Author in Contributions Dec 3, 2025
@Lunyachek Lunyachek force-pushed the lunyachel/feat/change-twitter-to-x-master branch from 5d57013 to 3fa7a13 Compare December 3, 2025 18:42
@codecov
Copy link

codecov bot commented Dec 3, 2025

Codecov Report

❌ Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 81.17%. Comparing base (bb88c09) to head (3fa7a13).
⚠️ Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
src/profile/forms/SocialLinks.jsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1186   +/-   ##
=======================================
  Coverage   81.17%   81.17%           
=======================================
  Files          51       51           
  Lines         834      834           
  Branches      232      240    +8     
=======================================
  Hits          677      677           
  Misses        150      150           
  Partials        7        7           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Lunyachek
Copy link
Contributor Author

@sarina I resolved all conflicts.

The repository currently doesn’t have tests for SocialLinks / mergeWithDrafts, so Codecov/patch fails.
I’d prefer not to introduce a new test suite in this PR just for a wording/identifier change — is it OK to ignore Codecov for this one?

@sarina
Copy link
Contributor

sarina commented Dec 3, 2025

That would be up to @jacobo-dominguez-wgu or @brian-smith-tcril

Copy link

@jacobo-dominguez-wgu jacobo-dominguez-wgu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not know if we can skip the codecov check or if we must create a new test suite, @brian-smith-tcril can you confirm that?

Copy link

@jacobo-dominguez-wgu jacobo-dominguez-wgu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Tested on my local and works well.

@brian-smith-tcril brian-smith-tcril merged commit 16de1d6 into openedx:master Dec 8, 2025
7 of 8 checks passed
@github-project-automation github-project-automation bot moved this from Waiting on Author to Done in Contributions Dec 8, 2025
@github-project-automation github-project-automation bot moved this from Backlog to Done in Aperture-Maintained Dec 8, 2025
@openedx-webhooks openedx-webhooks removed the waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. label Dec 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

open-source-contribution PR author is not from Axim or 2U

Projects

Status: Done
Status: Done

Development

Successfully merging this pull request may close these issues.

8 participants