-
Notifications
You must be signed in to change notification settings - Fork 137
feat: Change Twitter to X #1186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Change Twitter to X #1186
Conversation
|
Thanks for the pull request, @Lunyachek! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
3880d81 to
5d57013
Compare
|
Hi @openedx/2u-infinity - could someone please take a look at this? Thanks! |
sundasnoreen12
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hi @Lunyachek, test cases are failing. Could you please take a look?
|
@Lunyachek, test cases are failing |
|
@Lunyachek could you please rebase and address failing tests? We need to merge all 3 of the Twitter PRs before the release, or after, we can't do half and half. |
|
@Lunyachek please rebase this PR ASAP so we can get it merged now that the blocking PR has been merged. |
5d57013 to
3fa7a13
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1186 +/- ##
=======================================
Coverage 81.17% 81.17%
=======================================
Files 51 51
Lines 834 834
Branches 232 240 +8
=======================================
Hits 677 677
Misses 150 150
Partials 7 7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@sarina I resolved all conflicts. The repository currently doesn’t have tests for SocialLinks / mergeWithDrafts, so Codecov/patch fails. |
|
That would be up to @jacobo-dominguez-wgu or @brian-smith-tcril |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do not know if we can skip the codecov check or if we must create a new test suite, @brian-smith-tcril can you confirm that?
jacobo-dominguez-wgu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Tested on my local and works well.
Description
This PR is our proposal to update the Twitter icon to the new X logo in the user Profile and Account.
This PR is related to corresponding PRs in the edx-platform and frontend-app-account repositories.