improve: add pagination to clean collection

Author: daniloargentiero

Model/Clean.php

@@ -66,16 +66,24 @@ public function execute()
         $this->logger->info(__('Start webapi logs clean'));
         $hours = $this->config->getCleanOlderThanHours();
         $datetime = new DateTime('-' . $hours . ' hour');
+        $page = 1;
 
         $collection = $this->logCollectionFactory->create();
-        $rows = $collection->addFieldToFilter(LogResourceModel::CREATED_AT, ['lt' => $datetime])
-            ->getItems();
+        $collection = $collection->addFieldToSelect(LogResourceModel::LOG_ID)
+                                 ->addFieldToFilter(LogResourceModel::CREATED_AT, ['lt' => $datetime])
+                                 ->setPageSize(2);
 
-        $tot = $collection->count();
-
-        /** @var LogResourceModel $row */
-        foreach ($rows as $row) {
-            $this->logResourceModel->delete($row);
+        $pageCount = $collection->getLastPageNumber();
+        $currentPage = 1;
+        $tot = 0;
+        while ($currentPage <= $pageCount) {
+            $collection->setCurPage($currentPage);
+            foreach ($collection as $row) {
+                $this->logResourceModel->delete($row);
+                $tot++;
+            }
+            $collection->clear();
+            $currentPage++;
         }
 
         $this->logger->info(__('End webapi logs clean. Deleted %1 elements.', $tot));

Model/ResourceModel/LogResourceModel.php

@@ -15,6 +15,9 @@ class LogResourceModel extends AbstractDb
     /** @var string */
     const CREATED_AT = 'created_at';
 
+    /** @var string */
+    const LOG_ID = 'log_id';
+
     protected function _construct()
     {
         $this->_init('webapi_logs', 'log_id');

etc/crontab.xml

@@ -1,7 +1,7 @@
 <?xml version="1.0"?>
 <config xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
         xsi:noNamespaceSchemaLocation="urn:magento:module:Magento_Cron:etc/crontab.xsd">
-    <group id="general">
+    <group id="default">
         <job name="webapilogs_clean" instance="GhostUnicorns\WebapiLogs\Cron\CleanCron" method="execute">
             <schedule>0 * * * *</schedule>
         </job>