Skip to content

Commit 885e304

Browse files
committed
note tested, but runs the core init traj get
1 parent 2da6ef3 commit 885e304

File tree

2 files changed

+23
-3
lines changed

2 files changed

+23
-3
lines changed

paths_cli/parameters.py

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -64,8 +64,11 @@ def get(self, storage, name):
6464
result = None
6565
# if the we can get by name/number, do it
6666
if name is not None:
67-
# note: new storage may do a try/except here
68-
result = store[name]
67+
try:
68+
result = store[name]
69+
except:
70+
# on any error, we try everything else
71+
pass
6972

7073
if result is None:
7174
try:
@@ -98,6 +101,9 @@ def get(self, storage, name):
98101

99102
def init_traj_fallback(parameter, storage, name):
100103
result = None
104+
if isinstance(name, int):
105+
return storage.trajectories[name]
106+
101107
if name and os.path.isfile(name):
102108
# TODO: read from file
103109
pass
@@ -130,7 +136,7 @@ def init_traj_fallback(parameter, storage, name):
130136
param=Option('-t', '--init-traj',
131137
help="identifier for initial trajectory"),
132138
store='tags',
133-
num_store='trajectories',
139+
num_store='samplesets',
134140
fallback=init_traj_fallback
135141
)
136142

paths_cli/tests/test_parameters.py

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -187,6 +187,20 @@ def create_file(self, getter):
187187
])
188188
def test_get(self, getter):
189189
filename = self.create_file(getter)
190+
storage = paths.Storage(filename, mode='r')
191+
get_type, getter_style = self._parse_getter(getter)
192+
expected = {
193+
'sset': self.sample_set,
194+
'traj': self.traj
195+
}[get_type]
196+
get_arg = {
197+
'name': 'traj',
198+
'number': 0,
199+
'tag-final': 'final_conditions',
200+
'tag-initial': 'initial_conditions'
201+
}[getter_style]
202+
obj = self.PARAMETER.get(storage, get_arg)
203+
190204
pytest.skip()
191205
pass
192206

0 commit comments

Comments
 (0)