100% coverage of parameters.py

Author: dwhswenson

paths_cli/cli.py

@@ -42,7 +42,6 @@ def _list_plugins(self):
                 commands.append(command[:-3])
         return files, commands
 
-
     def list_commands(self, ctx):
         return list(self._get_command.keys())
 

paths_cli/parameters.py

@@ -11,12 +11,15 @@ def __init__(self, *args, **kwargs):
     def clicked(self, required=False):
         raise NotImplementedError()
 
+# we'll use tests of the -h option in the .travis.yml to ensure that the
+# .clicked methods work
+
 class Option(AbstractParameter):
-    def clicked(self, required=False):
+    def clicked(self, required=False):  # no-cov
         return click.option(*self.args, **self.kwargs, required=required)
 
 class Argument(AbstractParameter):
-    def clicked(self, required=False):
+    def clicked(self, required=False):  # no-cov
         return click.argument(*self.args, **self.kwargs, required=required)
 
 
@@ -25,11 +28,11 @@ def __init__(self, param):
         self.param = param
 
     @property
-    def clicked(self):
+    def clicked(self):  # no-cov
         return self.param.clicked
 
     def get(self, *args, **kwargs):
-        return NotImplementedError()
+        raise NotImplementedError()
 
 
 class StorageLoader(AbstractLoader):
@@ -83,17 +86,16 @@ def get(self, storage, name):
         if result is not None:
             return result
 
-
         # if only one is named, take it
-        if self.store != 'tags':
+        if self.store != 'tags' and name is None:
             # if there's only one of them, take that
             if len(store) == 1:
                 return store[0]
             named_things = [o for o in store if o.is_named]
             if len(named_things) == 1:
                 return named_things[0]
 
-        if len(num_store) == 1:
+        if len(num_store) == 1 and name is None:
             return num_store[0]
 
         if self.fallback:

paths_cli/tests/test_parameters.py

@@ -119,14 +119,21 @@ class TestSCHEME(ParamInstanceTest):
     def setup(self):
         super(TestSCHEME, self).setup()
         self.get_arg = {'name': 'scheme', 'number': 0, 'only': None,
-                        'only-named': None}
+                        'only-named': None, 'bad-name': 'foo'}
         self.obj = self.scheme
 
     @pytest.mark.parametrize("getter", ['name', 'number', 'only',
                                         'only-named'])
     def test_get(self, getter):
         self._getter_test(getter)
 
+    def test_bad_get(self):
+        # NOTE: This is where we test the failure of get; don't need to do
+        # it in every parameter
+        with pytest.raises(RuntimeError):
+            obj = self._getter_test('bad-name')
+
+
 
 class TestINIT_CONDS(ParamInstanceTest):
     PARAMETER = INIT_CONDS
@@ -269,3 +276,13 @@ def test_get_other(self, getter):
         self.get_arg = {'name': ['B'], 'number': [1]}
         self.obj = self.state_B
         self._getter_test(getter)
+
+def test_OUTPUT_FILE():
+    tempdir = tempfile.mkdtemp()
+    filename = os.path.join(tempdir, "test_output_file.nc")
+    assert not os.path.exists(filename)
+    storage = OUTPUT_FILE.get(filename)
+    assert os.path.exists(filename)
+    os.remove(filename)
+    os.rmdir(tempdir)
+