compile fail

[WinterChen]

When I build the stream-echo-nginx-module, Complitation failed with the errors as flow,
ngx_stream_echo_module.c:1146:9: 错误：隐式声明函数‘ngx_stream_close_connection [-Werror=implicit-function-declaration] ngx_stream_close_connection(c);
my gcc version is 4.8.5。
My nginx version is 1.15.9。

[WinterChen]

I read the code carefully, the function ngx_stream_close_connection is static defined in ngx_stream_handler.c，
static void ngx_stream_close_connection(ngx_connection_t *c);
it can not be used externally. I replace ngx_stream_close_connection whit ngx_stream_finalize_session, and complile successfully.
I think ngx_stream_close_connection maybe not static in the old verison of nginx

[agentzh]

@WinterChen Will you please create a github pull request for this fix? Many thanks. Not sure if we still want to support older versions of the nginx core. Maybe we could simply drop the support for older nginx versions.

[vndroid]

In fact, On the Alpine 3.10, Nginx 1.17.6 have same issues.

[vndroid]

Such as:

/usr/src/stream-echo-nginx-module/src/ngx_stream_echo_module.c: In function 'ngx_stream_echo_discarded_request_handler':
/usr/src/stream-echo-nginx-module/src/ngx_stream_echo_module.c:1146:9: error: implicit declaration of function 'ngx_stream_close_connection'; did you mean 'ngx_stream_init_connection'? [-Werror=implicit-function-declaration]
         ngx_stream_close_connection(c);
         ^~~~~~~~~~~~~~~~~~~~~~~~~~~
         ngx_stream_init_connection

and

cc1: all warnings being treated as errors
make[1]: *** [objs/Makefile:1824: objs/addon/src/ngx_stream_echo_module.o] Error 1
make[1]: *** Waiting for unfinished jobs....
make[1]: Leaving directory '/usr/src/nginx-1.17.6'
make: *** [Makefile:8: build] Error 2

[GongT]

Fedora 31 with newest master branch from https://github.com/nginx/nginx (master)

/usr/bin/ld: objs/addon/src/ngx_stream_echo_module.o: in function `ngx_stream_echo_lingering_close_handler':
/opt/source/nginx/../modules/stream-echo-nginx-module//src/ngx_stream_echo_module.c:1564: undefined reference to `ngx_stream_close_connection'
/usr/bin/ld: objs/addon/src/ngx_stream_echo_module.o: in function `ngx_stream_echo_finalize':
/opt/source/nginx/../modules/stream-echo-nginx-module//src/ngx_stream_echo_module.c:1455: undefined reference to `ngx_stream_close_connection'
/usr/bin/ld: objs/addon/src/ngx_stream_echo_module.o: in function `ngx_stream_echo_discarded_request_handler':
/opt/source/nginx/../modules/stream-echo-nginx-module//src/ngx_stream_echo_module.c:1146: undefined reference to `ngx_stream_close_connection'
collect2: error: ld returned 1 exit status

[agentzh]

Pull requests welcome. We no longer actively develop this module ourselves but we welcome patches from the community. Thanks.

[dpvmw]

we are still seeing this issue @agentzh , did this issue got fixed in any pull request
../stream-echo-nginx-module/src/ngx_stream_echo_module.c: In function ‘ngx_stream_echo_discarded_request_handler’:
../stream-echo-nginx-module/src/ngx_stream_echo_module.c:1146:9: error: implicit declaration of function ‘ngx_stream_close_connection’; did you mean ‘ngx_stream_init_connection’? [-Werror=implicit-function-declaration]
ngx_stream_close_connection(c);

@WinterChen do u have the pull request for this ?

[omeos]

config.patch

--- ./config	2016-12-19 06:41:48.000000000 +0800
+++ ./config.mod	2025-03-19 07:22:12.000000000 +0800
@@ -1,4 +1,23 @@
 ngx_addon_name=ngx_stream_echo_module
-STREAM_MODULES="$STREAM_MODULES ngx_stream_echo_module"
-NGX_ADDON_SRCS="$NGX_ADDON_SRCS $ngx_addon_dir/src/ngx_stream_echo_module.c"
-NGX_ADDON_DEPS="$NGX_ADDON_DEPS $ngx_addon_dir/src/ddebug.h"
+
+# add dynamic module supported for NGINX v1.9.11
+STUB_TYPE=STREAM
+STUB_DEPS="$ngx_addon_dir/src/ddebug.h"
+STUB_SRCS="$ngx_addon_dir/src/ngx_stream_echo_module.c"
+STUB_INCS=
+STUB_LIBS=
+if test -n "$ngx_module_link"; then
+   ngx_module_type="$STUB_TYPE"
+   ngx_module_name="$ngx_addon_name"
+   ngx_module_deps="$STUB_DEPS"
+   ngx_module_srcs="$STUB_SRCS"
+   ngx_module_incs="$STUB_INCS"
+   ngx_module_libs="$STUB_LIBS"
+   . auto/module
+else
+   eval "$STUB_TYPE"'_MODULES="$'"$STUB_TYPE"'_MODULES $ngx_addon_name"'
+   NGX_ADDON_DEPS="$NGX_ADDON_DEPS $STUB_DEPS"
+   NGX_ADDON_SRCS="$NGX_ADDON_SRCS $STUB_SRCS"
+   CORE_INCS="$CORE_INCS $STUB_INCS"
+   CORE_LIBS="$CORE_LIBS $STUB_LIBS"
+fi

src/ngx_stream_echo_module.c.patch

--- ./src/ngx_stream_echo_module.c	2016-12-19 06:41:48.000000000 +0800
+++ ./src/ngx_stream_echo_module.c.mod	2025-03-18 17:13:01.000000000 +0800
@@ -1143,7 +1143,7 @@
 
     if (rc == NGX_OK) {
         /* eof found */
-        ngx_stream_close_connection(c);
+        ngx_stream_finalize_session(s, rc); // ngx_stream_close_connection(c); // error: call to undeclared function 'ngx_stream_close_connection'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
         return;
     }
 
@@ -1374,7 +1374,7 @@
                    "stream echo finalize: rc=%i", rc);
 
     if (rc == NGX_ERROR || rc == NGX_DECLINED) {
-        ngx_stream_close_connection(c);
+        ngx_stream_finalize_session(s, rc); // ngx_stream_close_connection(c); // error: call to undeclared function 'ngx_stream_close_connection'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
         return;
     }
 
@@ -1382,7 +1382,7 @@
 
     ctx = ngx_stream_get_module_ctx(s, ngx_stream_echo_module);
     if (ctx == NULL) {
-        ngx_stream_close_connection(c);
+        ngx_stream_finalize_session(s, NGX_ERROR); // ngx_stream_close_connection(c); // error: call to undeclared function 'ngx_stream_close_connection'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
         return;
     }
 
@@ -1396,7 +1396,7 @@
         }
 
         if (ngx_handle_write_event(c->write, 0) != NGX_OK) {
-            ngx_stream_close_connection(c);
+            ngx_stream_finalize_session(s, NGX_ERROR); // ngx_stream_close_connection(c); // error: call to undeclared function 'ngx_stream_close_connection'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
         }
 
         return;
@@ -1411,7 +1411,7 @@
 
             if (ctx->busy == NULL) {
                 if (ngx_del_event(c->write, NGX_WRITE_EVENT, 0) != NGX_OK) {
-                    ngx_stream_close_connection(c);
+                    ngx_stream_finalize_session(s, NGX_ERROR); // ngx_stream_close_connection(c); // error: call to undeclared function 'ngx_stream_close_connection'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
                 }
             }
         }
@@ -1435,7 +1435,7 @@
 #endif
 
     if (c->error) {
-        ngx_stream_close_connection(c);
+        ngx_stream_finalize_session(s, NGX_ERROR); // ngx_stream_close_connection(c); // error: call to undeclared function 'ngx_stream_close_connection'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
         return;
     }
 
@@ -1452,7 +1452,7 @@
 
     dd("closing connection upon successful completion");
 
-    ngx_stream_close_connection(c);
+    ngx_stream_finalize_session(s, rc); // ngx_stream_close_connection(c); // error: call to undeclared function 'ngx_stream_close_connection'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
     return;
 }
 
@@ -1476,7 +1476,7 @@
     ngx_add_timer(rev, escf->lingering_timeout);
 
     if (ngx_handle_read_event(rev, 0) != NGX_OK) {
-        ngx_stream_close_connection(c);
+        ngx_stream_finalize_session(s, NGX_ERROR); // ngx_stream_close_connection(c); // error: call to undeclared function 'ngx_stream_close_connection'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
         return;
     }
 
@@ -1485,7 +1485,7 @@
 
     if (wev->active && (ngx_event_flags & NGX_USE_LEVEL_EVENT)) {
         if (ngx_del_event(wev, NGX_WRITE_EVENT, 0) != NGX_OK) {
-            ngx_stream_close_connection(c);
+            ngx_stream_finalize_session(s, NGX_ERROR); // ngx_stream_close_connection(c); // error: call to undeclared function 'ngx_stream_close_connection'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
             return;
         }
     }
@@ -1493,7 +1493,7 @@
     if (ngx_shutdown_socket(c->fd, NGX_WRITE_SHUTDOWN) == -1) {
         ngx_connection_error(c, ngx_socket_errno,
                              ngx_shutdown_socket_n " failed");
-        ngx_stream_close_connection(c);
+        ngx_stream_finalize_session(s, NGX_ERROR); // ngx_stream_close_connection(c); // error: call to undeclared function 'ngx_stream_close_connection'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
         return;
     }
 
@@ -1521,7 +1521,7 @@
                    "stream echo lingering close handler");
 
     if (rev->timedout) {
-        ngx_stream_close_connection(c);
+        ngx_stream_finalize_session(s, NGX_ERROR); // ngx_stream_close_connection(c); // error: call to undeclared function 'ngx_stream_close_connection'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
         return;
     }
 
@@ -1532,7 +1532,7 @@
 
     timer = (ngx_msec_t) ctx->lingering_time - (ngx_msec_t) ngx_time();
     if ((ngx_msec_int_t) timer <= 0) {
-        ngx_stream_close_connection(c);
+        ngx_stream_finalize_session(s, NGX_ERROR); // ngx_stream_close_connection(c); // error: call to undeclared function 'ngx_stream_close_connection'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
         return;
     }
 
@@ -1543,7 +1543,7 @@
                        "stream echo lingering read: %d", n);
 
         if (n == NGX_ERROR || n == 0) {
-            ngx_stream_close_connection(c);
+            ngx_stream_finalize_session(s, NGX_ERROR); // ngx_stream_close_connection(c); // error: call to undeclared function 'ngx_stream_close_connection'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
             return;
         }
 
@@ -1561,7 +1561,7 @@
     } while (rev->ready);
 
     if (ngx_handle_read_event(rev, 0) != NGX_OK) {
-        ngx_stream_close_connection(c);
+        ngx_stream_finalize_session(s, NGX_ERROR); // ngx_stream_close_connection(c); // error: call to undeclared function 'ngx_stream_close_connection'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
         return;
     }