Fixing test errors

Author: matteius

crates/diff-engine/src/changes.rs

@@ -281,7 +281,7 @@ impl ChangeClassifier {
 
     /// Comprehensive change classification with detailed analysis
     pub fn classify_change_detailed(
-        &self,
+        &mut self,
         source: Option<&CodeElement>,
         target: Option<&CodeElement>,
         source_ast: Option<&ASTNode>,
@@ -443,7 +443,7 @@ impl ChangeClassifier {
 
     /// Classify a modification (most complex case)
     fn classify_modification(
-        &self,
+        &mut self,
         source: &CodeElement,
         target: &CodeElement,
         source_ast: Option<&ASTNode>,
@@ -459,7 +459,7 @@ impl ChangeClassifier {
         // Calculate similarity metrics if AST and signatures are available
         let similarity_metrics = if let (Some(src_ast), Some(tgt_ast), Some(src_sig), Some(tgt_sig)) =
             (source_ast, target_ast, source_signature, target_signature) {
-            if let Some(scorer) = &mut self.similarity_scorer {
+            if let Some(ref mut scorer) = self.similarity_scorer {
                 Some(scorer.calculate_comprehensive_similarity(src_sig, src_ast, tgt_sig, tgt_ast)?)
             } else {
                 None
@@ -552,13 +552,13 @@ impl ChangeClassifier {
         if let Some(metrics) = &similarity_metrics {
             characteristics.push(ChangeCharacteristic {
                 characteristic_type: CharacteristicType::StructuralSimilarity,
-                value: format!("{:.3}", metrics.ast_similarity.structural_similarity),
+                value: format!("{:.3}", metrics.body_similarity.structural_similarity),
                 confidence: 0.9,
             });
 
             characteristics.push(ChangeCharacteristic {
                 characteristic_type: CharacteristicType::ContentSimilarity,
-                value: format!("{:.3}", metrics.ast_similarity.content_similarity),
+                value: format!("{:.3}", metrics.body_similarity.content_similarity),
                 confidence: 0.9,
             });
 
@@ -567,9 +567,9 @@ impl ChangeClassifier {
                 description: format!("AST similarity: {:.3}", metrics.overall_similarity),
                 strength: metrics.overall_similarity,
                 data: [
-                    ("structural_similarity".to_string(), metrics.ast_similarity.structural_similarity.to_string()),
-                    ("content_similarity".to_string(), metrics.ast_similarity.content_similarity.to_string()),
-                    ("control_flow_similarity".to_string(), metrics.ast_similarity.control_flow_similarity.to_string()),
+                    ("structural_similarity".to_string(), metrics.body_similarity.structural_similarity.to_string()),
+                    ("content_similarity".to_string(), metrics.body_similarity.content_similarity.to_string()),
+                    ("control_flow_similarity".to_string(), metrics.body_similarity.control_flow_similarity.to_string()),
                 ].into_iter().collect(),
             });
         }
@@ -897,12 +897,12 @@ impl ChangeClassifier {
                     effort_level = EffortLevel::Medium;
                     risk_level = RiskLevel::Medium;
                 }
-            }
 
-            if complexity > 20 {
-                impact_level = ImpactLevel::High;
-                effort_level = EffortLevel::High;
-                risk_level = RiskLevel::High;
+                if complexity > 20 {
+                    impact_level = ImpactLevel::High;
+                    effort_level = EffortLevel::High;
+                    risk_level = RiskLevel::High;
+                }
             }
 
             // Public functions have higher impact

crates/diff-engine/src/engine.rs

@@ -64,7 +64,7 @@ impl DiffEngine {
         Self {
             function_matcher: FunctionMatcher::new(0.7),
             tree_edit_distance: TreeEditDistance::new(ZhangShashaConfig::default()),
-            change_classifier: ChangeClassifier::new(language, ChangeClassificationConfig::default()),
+            change_classifier: ChangeClassifier::new(language),
             refactoring_detector: RefactoringDetector::new(language),
         }
     }

crates/diff-engine/src/refactoring.rs

@@ -373,7 +373,7 @@ impl RefactoringDetector {
 
     /// Detect refactoring patterns with detailed analysis
     pub fn detect_patterns_detailed(
-        &self,
+        &mut self,
         changes: &[Change],
         source_asts: &HashMap<String, ASTNode>,
         target_asts: &HashMap<String, ASTNode>,
@@ -576,7 +576,7 @@ impl RefactoringDetector {
                         description: format!(
                             "Extracted method '{}' from '{}'",
                             target.name,
-                            modified.source.as_ref().map(|s| &s.name).unwrap_or("unknown")
+                            modified.source.as_ref().map(|s| s.name.as_str()).unwrap_or("unknown")
                         ),
                         affected_elements: vec![
                             target.name.clone(),
@@ -596,7 +596,7 @@ impl RefactoringDetector {
 
     /// Calculate confidence for extract method pattern
     fn calculate_extract_method_confidence(&self, modified: &Change, added: &Change) -> f64 {
-        let mut confidence = 0.0;
+        let mut confidence: f64 = 0.0;
 
         // Base confidence for the pattern structure
         confidence += 0.4;
@@ -1012,7 +1012,7 @@ impl RefactoringDetector {
 
     /// Detect extract method patterns with detailed analysis
     fn detect_extract_method_detailed(
-        &self,
+        &mut self,
         change_groups: &[Vec<&Change>],
         source_asts: &HashMap<String, ASTNode>,
         target_asts: &HashMap<String, ASTNode>,
@@ -1070,7 +1070,7 @@ impl RefactoringDetector {
 
     /// Calculate detailed confidence for extract method pattern
     fn calculate_detailed_extract_method_confidence(
-        &self,
+        &mut self,
         modified: &Change,
         added: &Change,
         source_ast: Option<&ASTNode>,
@@ -1105,9 +1105,10 @@ impl RefactoringDetector {
         }
 
         // AST analysis
-        if let (Some(src_ast), Some(tgt_ast)) = (source_ast, target_ast) {
-            if let Some(scorer) = &self.similarity_scorer {
-                let similarity = scorer.calculate_comprehensive_similarity(src_ast, tgt_ast)?;
+        if let (Some(src_ast), Some(tgt_ast), Some(src_sig), Some(tgt_sig)) =
+            (source_ast, target_ast, source_sig, target_sig) {
+            if let Some(ref mut scorer) = self.similarity_scorer {
+                let similarity = scorer.calculate_comprehensive_similarity(src_sig, src_ast, tgt_sig, tgt_ast)?;
 
                 // Some similarity expected (shared patterns) but not too high
                 if similarity.overall_similarity > 0.3 && similarity.overall_similarity < 0.8 {

frontend/.gitignore

@@ -0,0 +1,24 @@
+# Logs
+logs
+*.log
+npm-debug.log*
+yarn-debug.log*
+yarn-error.log*
+pnpm-debug.log*
+lerna-debug.log*
+
+node_modules
+dist
+dist-ssr
+*.local
+
+# Editor directories and files
+.vscode/*
+!.vscode/extensions.json
+.idea
+.DS_Store
+*.suo
+*.ntvs*
+*.njsproj
+*.sln
+*.sw?

frontend/README.md

@@ -0,0 +1,73 @@
+# React + TypeScript + Vite
+
+This template provides a minimal setup to get React working in Vite with HMR and some ESLint rules.
+
+Currently, two official plugins are available:
+
+- [@vitejs/plugin-react](https://github.com/vitejs/vite-plugin-react/blob/main/packages/plugin-react) uses [Babel](https://babeljs.io/) for Fast Refresh
+- [@vitejs/plugin-react-swc](https://github.com/vitejs/vite-plugin-react/blob/main/packages/plugin-react-swc) uses [SWC](https://swc.rs/) for Fast Refresh
+
+## React Compiler
+
+The React Compiler is not enabled on this template because of its impact on dev & build performances. To add it, see [this documentation](https://react.dev/learn/react-compiler/installation).
+
+## Expanding the ESLint configuration
+
+If you are developing a production application, we recommend updating the configuration to enable type-aware lint rules:
+
+```js
+export default defineConfig([
+  globalIgnores(['dist']),
+  {
+    files: ['**/*.{ts,tsx}'],
+    extends: [
+      // Other configs...
+
+      // Remove tseslint.configs.recommended and replace with this
+      tseslint.configs.recommendedTypeChecked,
+      // Alternatively, use this for stricter rules
+      tseslint.configs.strictTypeChecked,
+      // Optionally, add this for stylistic rules
+      tseslint.configs.stylisticTypeChecked,
+
+      // Other configs...
+    ],
+    languageOptions: {
+      parserOptions: {
+        project: ['./tsconfig.node.json', './tsconfig.app.json'],
+        tsconfigRootDir: import.meta.dirname,
+      },
+      // other options...
+    },
+  },
+])
+```
+
+You can also install [eslint-plugin-react-x](https://github.com/Rel1cx/eslint-react/tree/main/packages/plugins/eslint-plugin-react-x) and [eslint-plugin-react-dom](https://github.com/Rel1cx/eslint-react/tree/main/packages/plugins/eslint-plugin-react-dom) for React-specific lint rules:
+
+```js
+// eslint.config.js
+import reactX from 'eslint-plugin-react-x'
+import reactDom from 'eslint-plugin-react-dom'
+
+export default defineConfig([
+  globalIgnores(['dist']),
+  {
+    files: ['**/*.{ts,tsx}'],
+    extends: [
+      // Other configs...
+      // Enable lint rules for React
+      reactX.configs['recommended-typescript'],
+      // Enable lint rules for React DOM
+      reactDom.configs.recommended,
+    ],
+    languageOptions: {
+      parserOptions: {
+        project: ['./tsconfig.node.json', './tsconfig.app.json'],
+        tsconfigRootDir: import.meta.dirname,
+      },
+      // other options...
+    },
+  },
+])
+```

frontend/eslint.config.js

@@ -0,0 +1,23 @@
+import js from '@eslint/js'
+import globals from 'globals'
+import reactHooks from 'eslint-plugin-react-hooks'
+import reactRefresh from 'eslint-plugin-react-refresh'
+import tseslint from 'typescript-eslint'
+import { defineConfig, globalIgnores } from 'eslint/config'
+
+export default defineConfig([
+  globalIgnores(['dist']),
+  {
+    files: ['**/*.{ts,tsx}'],
+    extends: [
+      js.configs.recommended,
+      tseslint.configs.recommended,
+      reactHooks.configs['recommended-latest'],
+      reactRefresh.configs.vite,
+    ],
+    languageOptions: {
+      ecmaVersion: 2020,
+      globals: globals.browser,
+    },
+  },
+])

frontend/index.html

@@ -0,0 +1,13 @@
+<!doctype html>
+<html lang="en">
+  <head>
+    <meta charset="UTF-8" />
+    <link rel="icon" type="image/svg+xml" href="/vite.svg" />
+    <meta name="viewport" content="width=device-width, initial-scale=1.0" />
+    <title>frontend</title>
+  </head>
+  <body>
+    <div id="root"></div>
+    <script type="module" src="/src/main.tsx"></script>
+  </body>
+</html>