Fixing test errors

Author: matteius

crates/diff-engine/src/changes.rs

@@ -1022,7 +1022,7 @@ impl ChangeClassifier {
 
             // Visibility changes
             if src_sig.visibility != tgt_sig.visibility {
-                match (src_sig.visibility, tgt_sig.visibility) {
+                match (&src_sig.visibility, &tgt_sig.visibility) {
                     (smart_diff_semantic::Visibility::Public, _) => {
                         // Making public function less visible is breaking
                         is_breaking_change = true;
@@ -1121,16 +1121,16 @@ impl ChangeClassifier {
 
     /// Update configuration
     pub fn set_config(&mut self, config: ChangeClassificationConfig) {
-        self.config = config;
-
-        // Update tree edit distance configuration
+        // Update tree edit distance configuration before moving config
         let tree_config = ZhangShashaConfig {
             enable_caching: true,
             enable_pruning: true,
             max_depth: config.max_ast_depth,
             ..Default::default()
         };
         self.tree_edit_distance.set_config(tree_config);
+
+        self.config = config;
     }
 
     /// Enable or disable semantic analysis

crates/diff-engine/src/cross_file_tracker.rs

@@ -934,13 +934,13 @@ impl CrossFileTracker {
 
     /// Update configuration
     pub fn set_config(&mut self, config: CrossFileTrackerConfig) {
-        self.config = config;
-
-        // Update Hungarian matcher config
+        // Update Hungarian matcher config before moving config
         let mut hungarian_config = self.hungarian_matcher.get_config().clone();
         hungarian_config.cross_file_penalty = config.cross_file_move_penalty;
         hungarian_config.min_similarity_threshold = config.min_cross_file_similarity;
         self.hungarian_matcher.set_config(hungarian_config);
+
+        self.config = config;
     }
 
     /// Clear caches

crates/diff-engine/src/refactoring.rs

@@ -387,18 +387,29 @@ impl RefactoringDetector {
         }
 
         // Enhanced pattern detection with AST and signature analysis
-        let change_groups = self.group_related_changes(changes);
+        let change_groups = {
+            // Create a temporary scope to avoid borrow conflicts
+            let groups = self.group_related_changes(changes);
+            // Clone the groups to avoid lifetime issues
+            groups.into_iter().map(|group| group.into_iter().cloned().collect::<Vec<_>>()).collect::<Vec<_>>()
+        };
 
         // Detect patterns with detailed analysis
         if self.config.enable_extract_method {
+            let group_refs: Vec<Vec<&Change>> = change_groups.iter()
+                .map(|group| group.iter().collect())
+                .collect();
             patterns.extend(self.detect_extract_method_detailed(
-                &change_groups, source_asts, target_asts, source_signatures, target_signatures
+                &group_refs, source_asts, target_asts, source_signatures, target_signatures
             )?);
         }
 
         if self.config.enable_inline_method {
+            let group_refs: Vec<Vec<&Change>> = change_groups.iter()
+                .map(|group| group.iter().collect())
+                .collect();
             patterns.extend(self.detect_inline_method_detailed(
-                &change_groups, source_asts, target_asts, source_signatures, target_signatures
+                &group_refs, source_asts, target_asts, source_signatures, target_signatures
             )?);
         }