Fixing test errors

Author: matteius

crates/semantic-analysis/src/symbol_table.rs

@@ -324,7 +324,7 @@ impl SymbolTable {
             let file_symbols = self
                 .file_symbols
                 .entry(file_path)
-                .or_insert_with(HashMap::new);
+                .or_default();
             for (name, symbol) in symbols {
                 file_symbols.insert(name, symbol);
             }
@@ -354,11 +354,12 @@ impl SymbolTable {
 
     /// Get statistics about the symbol table
     pub fn get_statistics(&self) -> SymbolTableStats {
-        let mut stats = SymbolTableStats::default();
-
-        stats.total_symbols = self.global_symbols.len();
-        stats.total_scopes = self.scoped_symbols.len();
-        stats.total_files = self.file_symbols.len();
+        let mut stats = SymbolTableStats {
+            total_symbols: self.global_symbols.len(),
+            total_scopes: self.scoped_symbols.len(),
+            total_files: self.file_symbols.len(),
+            ..Default::default()
+        };
 
         // Count symbols by kind
         for symbols in self.file_symbols.values() {

crates/semantic-analysis/src/type_dependency_graph.rs

@@ -180,7 +180,7 @@ impl TypeDependencyGraphBuilder {
         }
 
         // Add generic parameter dependencies
-        for (_param_name, constraints) in &extracted_type.generic_constraints {
+        for constraints in extracted_type.generic_constraints.values() {
             for constraint in constraints {
                 self.add_relationship(
                     type_name,

crates/semantic-analysis/src/type_extractor.rs

@@ -431,9 +431,9 @@ impl TypeExtractor {
             .clone();
 
         let visibility = self.extract_visibility(node);
-        let is_static = node.metadata.attributes.get("static").is_some();
-        let is_final = node.metadata.attributes.get("final").is_some()
-            || node.metadata.attributes.get("const").is_some();
+        let is_static = node.metadata.attributes.contains_key("static");
+        let is_final = node.metadata.attributes.contains_key("final")
+            || node.metadata.attributes.contains_key("const");
 
         let field_info = FieldInfo {
             name: name.clone(),
@@ -496,9 +496,9 @@ impl TypeExtractor {
             .clone();
 
         let visibility = self.extract_visibility(node);
-        let is_static = node.metadata.attributes.get("static").is_some();
-        let is_abstract = node.metadata.attributes.get("abstract").is_some();
-        let _is_final = node.metadata.attributes.get("final").is_some();
+        let is_static = node.metadata.attributes.contains_key("static");
+        let is_abstract = node.metadata.attributes.contains_key("abstract");
+        let _is_final = node.metadata.attributes.contains_key("final");
 
         // Extract parameters
         let parameters = self.extract_method_parameters(node)?;

crates/semantic-analysis/src/type_system.rs

@@ -255,9 +255,10 @@ impl TypeSignature {
         self.modifiers = modifiers;
         self
     }
+}
 
-    /// Convert to string representation
-    pub fn to_string(&self) -> String {
+impl std::fmt::Display for TypeSignature {
+    fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
         let mut result = self.base_type.clone();
 
         // Add generic parameters
@@ -276,9 +277,11 @@ impl TypeSignature {
             result.push('?');
         }
 
-        result
+        write!(f, "{}", result)
     }
+}
 
+impl TypeSignature {
     /// Parse type signature from string
     pub fn parse(type_str: &str) -> Result<Self, String> {
         let mut signature = TypeSignature::new(String::new());
@@ -326,7 +329,7 @@ impl TypeSignature {
         let mut current_param = String::new();
         let mut depth = 0;
 
-        while let Some(ch) = chars.next() {
+        for ch in chars.by_ref() {
             match ch {
                 '>' if depth == 0 => break,
                 '<' => {