OCPBUGS-87484: Updating ose-installer-container image to be consistent with ART for 5.0#10601
Conversation
|
Created by ART pipeline job run https://art-jenkins.apps.prod-stable-spoke1-dc-iad2.itup.redhat.com/job/aos-cd-builds/job/build%252Fsync-ci-images/216 |
openshift-bot
changed the title
|
Note
|
| Layer / File(s) | Summary |
|---|---|
CI operator build root image .ci-operator.yaml |
Build root image tag updated from rhel-9-release-golang-1.25-openshift-4.22 to rhel-9-release-golang-1.26-openshift-5.0. |
Installer Dockerfile stage and base image tags images/installer/Dockerfile.ci |
Multi-stage FROM references for kas-artifacts, etcd-artifacts, and builder stages updated to OpenShift 5.0. Final base image stage (base-rhel9) also updated to the 5.0 variant. |
🎯 1 (Trivial) | ⏱️ ~3 minutes
🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
| Check name | Status | Explanation |
|---|---|---|
| Description Check | ✅ Passed | Check skipped - CodeRabbit’s high-level summary is enabled. |
| Docstring Coverage | ✅ Passed | No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. |
| Linked Issues check | ✅ Passed | Check skipped because no linked issues were found for this pull request. |
| Out of Scope Changes check | ✅ Passed | Check skipped because no linked issues were found for this pull request. |
| Stable And Deterministic Test Names | ✅ Passed | PR modifies only CI/build configuration files (.ci-operator.yaml and Dockerfile.ci), not test code. The Ginkgo test naming check is not applicable to configuration-only changes. |
| Test Structure And Quality | ✅ Passed | PR contains no Ginkgo test code—only CI configuration (.ci-operator.yaml) and Dockerfile updates. Check for test structure quality is not applicable. |
| Microshift Test Compatibility | ✅ Passed | No new Ginkgo e2e tests (It, Describe, Context, When) were added in this PR. Changes are configuration-only (.ci-operator.yaml and Dockerfile.ci updates for OpenShift 5.0). |
| Single Node Openshift (Sno) Test Compatibility | ✅ Passed | PR contains only CI infrastructure configuration changes (build_root_image tag and Dockerfile image references), not new Ginkgo e2e tests. SNO compatibility check is not applicable. |
| Topology-Aware Scheduling Compatibility | ✅ Passed | PR modifies only CI/CD build configuration files (.ci-operator.yaml and Dockerfile.ci), not deployment manifests, operator code, or controllers. No scheduling constraints are introduced. |
| Ote Binary Stdout Contract | ✅ Passed | PR modifies only CI configuration and Docker build files, not source code. OTE stdout contract check does not apply to infrastructure changes. |
| Ipv6 And Disconnected Network Test Compatibility | ✅ Passed | No Ginkgo e2e tests added. PR only updates CI configuration (.ci-operator.yaml) and container build definition (Dockerfile.ci), not test code. |
| No-Weak-Crypto | ✅ Passed | PR updates CI build infrastructure configuration only (base image versions in .ci-operator.yaml and Dockerfile.ci). No cryptographic code, weak crypto functions, or secret comparisons are introduced. |
| Container-Privileges | ✅ Passed | PR updates container base image tags. No K8s manifests or container privilege settings (privileged, hostPID, SYS_ADMIN, etc.) found in changes. Dockerfile runs as non-root user. |
| No-Sensitive-Data-In-Logs | ✅ Passed | PR contains only version/image tag updates for CI build consistency. No logging statements, passwords, tokens, PII, session IDs, hostnames, or customer data are exposed in the changes. |
| Title check | ✅ Passed | The title directly describes the main change: updating the ose-installer-container image configuration to align with ART for OpenShift 5.0, which matches the file modifications in .ci-operator.yaml and images/installer/Dockerfile.ci. |
✏️ Tip: You can configure your own custom pre-merge checks in the settings.
✨ Finishing Touches
🧪 Generate unit tests (beta)
- Create PR with unit tests
Comment @coderabbitai help to get the list of available commands and usage tips.
openshift-ci-robot
added
jira/valid-reference
|
@openshift-bot: This pull request references Jira Issue OCPBUGS-87484, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@openshift-bot: This pull request references Jira Issue OCPBUGS-87484, which is valid. 3 validation(s) were run on this bug
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
images/installer/Dockerfile.ci (1)
5-22:⚠️ Potential issue | 🔴 CriticalUPI CI Dockerfile is still pinned to OpenShift 4.22 while CI Dockerfile is updated to 5.0.
images/installer/Dockerfile.upi.cistill referencesocp/4.22forkas-artifacts,etcd-artifacts,builder(rhel-9-golang-1.25-openshift-4.22),cli, andbase-rhel9. If UPI should match the 5.0 update inimages/installer/Dockerfile.ci, align these stages toocp/5.0(and the matching builder/golang version).🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@images/installer/Dockerfile.ci` around lines 5 - 22, The UPI CI Dockerfile still pins multiple stages to ocp/4.22; update the FROM lines for kas-artifacts, etcd-artifacts, builder, cli and base-rhel9 in images/installer/Dockerfile.upi.ci to use ocp/5.0, and change the builder image tag from rhel-9-golang-1.25-openshift-4.22 to the matching rhel-9-golang-1.26-openshift-5.0 (or the exact builder image used in the CI Dockerfile.ci), ensuring stage names kas-artifacts, etcd-artifacts, builder, cli and base-rhel9 remain the same so paths and COPY --from references still resolve.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Outside diff comments:
In `@images/installer/Dockerfile.ci`:
- Around line 5-22: The UPI CI Dockerfile still pins multiple stages to
ocp/4.22; update the FROM lines for kas-artifacts, etcd-artifacts, builder, cli
and base-rhel9 in images/installer/Dockerfile.upi.ci to use ocp/5.0, and change
the builder image tag from rhel-9-golang-1.25-openshift-4.22 to the matching
rhel-9-golang-1.26-openshift-5.0 (or the exact builder image used in the CI
Dockerfile.ci), ensuring stage names kas-artifacts, etcd-artifacts, builder, cli
and base-rhel9 remain the same so paths and COPY --from references still
resolve.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: ab334615-5c3d-4078-ac0d-743b3500acbd
📒 Files selected for processing (2)
.ci-operator.yamlimages/installer/Dockerfile.ci
|
@openshift-bot: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
ART wants to connect issue OCPBUGS-87738 to this PR, but found it is currently hooked up to ['OCPBUGS-87484']. Please consult with #forum-ocp-art if it is not clear what there is to do. |
2 participants
Updating ose-installer-container image to be consistent with ART for 5.0
TLDR:
Product builds by ART can be configured for different base and builder images than corresponding CI
builds. This automated PR requests a change to CI configuration to align with ART's configuration;
please take steps to merge it quickly or contact ART to coordinate changes.
The configuration in the following ART component metadata is driving this alignment request:
ose-installer.yml.
Detail:
This repository is out of sync with the downstream product builds for this component. The CI
configuration for at least one image differs from ART's expected product configuration. This should
be addressed to ensure that the component's CI testing accurate reflects what customers will
experience.
Most of these PRs are opened as an ART-driven proposal to migrate base image or builder(s) to a
different version, usually prior to GA. The intent is to effect changes in both configurations
simultaneously without breaking either CI or ART builds, so usually ART builds are configured to
consider CI as canonical and attempt to match CI config until the PR merges to align both. ART may
also configure changes in GA releases with CI remaining canonical for a brief grace period to enable
CI to succeed and the alignment PR to merge. In either case, ART configuration will be made
canonical at some point (typically at branch-cut before GA or release dev-cut after GA), so it is
important to align CI configuration as soon as possible.
PRs are also triggered when CI configuration changes without ART coordination, for instance to
change the number of builder images or to use a different golang version. These changes should be
coordinated with ART; whether ART configuration is canonical or not, preferably it would be updated
first to enable the changes to occur simultaneously in both CI and ART at the same time. This also
gives ART a chance to validate the intended changes first. For instance, ART compiles most
components with the Golang version being used by the control plane for a given OpenShift release.
Exceptions to this convention (i.e. you believe your component must be compiled with a Golang
version independent from the control plane) must be granted by the OpenShift staff engineers and
communicated to the ART team.
Roles & Responsibilities:
tests OR that necessary metadata changes are reported to the ART team
in
#forum-ocp-arton Slack. If necessary, the changes required by this pull request can beintroduced with a separate PR opened by the component team. Once the repository is aligned,
this PR will be closed automatically.
verify-depsis complaining. In that case, please opena new PR with the dependency issues addressed (and base images bumped). ART-9595 for reference.
any required labels to ensure the PR merges once tests are passing. In cases where ART config is
canonical, downstream builds are already being built with these changes, and merging this PR
only improves the fidelity of our CI. In cases where ART config is not canonical, this provides
a grace period for the component team to align their CI with ART's configuration before it becomes
canonical in product builds.
ART has been configured to reconcile your CI build root image (see https://docs.ci.openshift.org/docs/architecture/ci-operator/#build-root-image).
In order for your upstream .ci-operator.yaml configuration to be honored, you must set the following in your openshift/release ci-operator configuration file:
Change behavior of future PRs:
set up automatically. This means that such a PR would merge without human intervention (and awareness!) in the future.
To do so, open a PR to set the
auto_labelattribute in the image configuration. ExampleUPSTREAM: <carry>:. An example.If you have any questions about this pull request, please reach out in the
#forum-ocp-artSlack channel.Summary by CodeRabbit